[coreboot-gerrit] New patch to review for coreboot: 119873d peppy: Add an inverted input GPIO type
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Wed Nov 20 02:22:25 CET 2013
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4247
-gerrit
commit 119873d7a671c48169849f0e1bd2f7520906837b
Author: Shawn Nematbakhsh <shawnn at google.com>
Date: Tue Jun 11 20:30:09 2013 -0700
peppy: Add an inverted input GPIO type
The wake device input pins are active low and the
GPIOs need to be set as inverted when they are marked
as an input so they are not spuriously logged.
Also sync pin states from Falco initial commit.
Reference change: I15d38dcc9b2fb4b2b0eb27da358fa3c343e22323
Change-Id: I66e136d389d53a367436d816fa84dacdc8e86bad
Reviewed-on: https://gerrit.chromium.org/gerrit/58334
Tested-by: Shawn Nematbakhsh <shawnn at chromium.org>
Reviewed-by: Dave Parker <dparker at chromium.org>
Commit-Queue: Shawn Nematbakhsh <shawnn at chromium.org>
Signed-off-by: Shawn Nematbakhsh <shawnn at google.com>
---
src/mainboard/google/peppy/gpio.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mainboard/google/peppy/gpio.h b/src/mainboard/google/peppy/gpio.h
index 7c023b5..dab086a 100644
--- a/src/mainboard/google/peppy/gpio.h
+++ b/src/mainboard/google/peppy/gpio.h
@@ -35,7 +35,7 @@ const struct pch_lp_gpio_map mainboard_gpio_map[] = {
LP_GPIO_INPUT, /* 9: RAM_ID1 */
LP_GPIO_ACPI_SCI, /* 10: WLAN_WAKE_L_Q */
LP_GPIO_UNUSED, /* 11: UNUSED */
- LP_GPIO_IRQ_EDGE, /* 12: TRACKPAD_INT_L */
+ LP_GPIO_INPUT_INVERT, /* 12: TRACKPAD_INT_L (WAKE) */
LP_GPIO_INPUT, /* 13: RAM_ID0 */
LP_GPIO_INPUT, /* 14: EC_IN_RW */
LP_GPIO_UNUSED, /* 15: UNUSED (STRAP) */
@@ -48,7 +48,7 @@ const struct pch_lp_gpio_map mainboard_gpio_map[] = {
LP_GPIO_UNUSED, /* 22: UNUSED */
LP_GPIO_UNUSED, /* 23: UNUSED */
LP_GPIO_UNUSED, /* 24: UNUSED */
- LP_GPIO_IRQ_EDGE, /* 25: TOUCH_INT_L */
+ LP_GPIO_INPUT_INVERT, /* 25: TOUCH_INT_L (WAKE) */
LP_GPIO_UNUSED, /* 26: UNUSED */
LP_GPIO_UNUSED, /* 27: UNUSED */
LP_GPIO_UNUSED, /* 28: UNUSED */
@@ -74,10 +74,10 @@ const struct pch_lp_gpio_map mainboard_gpio_map[] = {
LP_GPIO_UNUSED, /* 48: UNUSED */
LP_GPIO_UNUSED, /* 49: UNUSED */
LP_GPIO_UNUSED, /* 50: UNUSED */
- LP_GPIO_IRQ_EDGE, /* 51: ALS_INT_L */
- LP_GPIO_IRQ_EDGE, /* 52: SIM_DET */
- LP_GPIO_ACPI_SCI, /* 53: TRACKPAD_INT_DX (WAKE) */
- LP_GPIO_ACPI_SCI, /* 54: TOUCH_INT_L_DX (WAKE) */
+ LP_GPIO_INPUT, /* 51: ALS_INT_L */
+ LP_GPIO_INPUT, /* 52: SIM_DET */
+ LP_GPIO_PIRQ, /* 53: TRACKPAD_INT_DX */
+ LP_GPIO_PIRQ, /* 54: TOUCH_INT_L_DX */
LP_GPIO_UNUSED, /* 55: UNUSED */
LP_GPIO_UNUSED, /* 56: UNUSED */
LP_GPIO_OUT_HIGH, /* 57: PP3300_CCD_EN */
More information about the coreboot-gerrit
mailing list