[coreboot-gerrit] Patch merged into coreboot/master: a967f41 libpayload: usb mass storage detect empty media

gerrit at coreboot.org gerrit at coreboot.org
Mon Nov 25 23:56:15 CET 2013

the following patch was just integrated into master:
commit a967f414dfb1f85097ba7ca2f00fdc7f415da776
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Jun 6 16:14:21 2013 -0500

    libpayload: usb mass storage detect empty media
    There is currently a hard-coded 30 sec delay in the mass storage
    driver while waiting for each device to become ready. However, mass
    storage card readers that are empty return an error code on the
    TEST UNIT READY command. A REQUEST SENSE command then needs to be
    issued and interrogate the data to determine if no media is present.
    If no media determination is found to be true the USB device is no
    longer considered a candidate to be a disk.
    This code does lead to the fact that the media card reader needs to be
    populated at enumeration time. I suspect this is not an issue as it
    appears the storage stack in libpayload can't handle removable media
    coming online later.
    Booted recovery and dev modes. Noted that removable mass storage
    devices with no media were ignored without any boot delay.
    Change-Id: Ida7a45614d97c6e6fbfc9bb099765aad4df550fd
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/57828
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/4225
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

See http://review.coreboot.org/4225 for details.


More information about the coreboot-gerrit mailing list