[coreboot-gerrit] Patch set updated for coreboot: af4bb56 southbridge/via/vt8237r/ctrl.c: Remove set but unused variable `regm3`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Oct 21 23:30:27 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3985


commit af4bb566b8eef04ac6f7481bb175cfe3f91d0d9c
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Oct 20 00:41:28 2013 +0200

    southbridge/via/vt8237r/ctrl.c: Remove set but unused variable `regm3`
    Removing `-Wno-unused-but-set-variable` from `CFLAGS` results in the
    following error.
    	    CC         southbridge/via/vt8237r/ctrl.ramstage.o
    	src/southbridge/via/vt8237r/ctrl.c: In function 'vt8237_cfg':
    	src/southbridge/via/vt8237r/ctrl.c:32:11: error: variable 'regm3' set but not used [-Werror=unused-but-set-variable]
    	cc1: all warnings being treated as errors
    There is already a `FIXME` line regarding this issue, added in commit
    »remove more warnings.« (3c8ac786).
    Looking at the history, the file `vt8237_ctrl.c` was based on
    `k8t890_ctrl.c`, but removed the code needing the variable `regm3` and
    was not adapted in that place.
    Therefore remove the variable `regm3` and use `regm` which should also
    shadow page E correctly now.
    Change-Id: I6bb652419a54b7b7190e417346581f38335425ae
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/southbridge/via/vt8237r/ctrl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/southbridge/via/vt8237r/ctrl.c b/src/southbridge/via/vt8237r/ctrl.c
index 78a15e3..e61b8f2 100644
--- a/src/southbridge/via/vt8237r/ctrl.c
+++ b/src/southbridge/via/vt8237r/ctrl.c
@@ -29,7 +29,7 @@
 static void vt8237_cfg(struct device *dev)
-	u8 regm, regm3;
+	u8 regm;
 	device_t devfun3;
 	devfun3 = dev_find_device(PCI_VENDOR_ID_VIA,
@@ -80,8 +80,7 @@ static void vt8237_cfg(struct device *dev)
 	regm = pci_read_config8(devfun3, 0x83);
 	pci_write_config8(dev, 0x63, regm);
-	// FIXME is this really supposed to be regm3?
-	regm3 = pci_read_config8(devfun3, 0x82);/* Shadow page E */
+	regm = pci_read_config8(devfun3, 0x82);/* Shadow page E */
 	pci_write_config8(dev, 0x64, regm);
 	regm = pci_read_config8(devfun3, 0x86);	/* SMM and APIC decoding */

More information about the coreboot-gerrit mailing list