[coreboot-gerrit] New patch to review for coreboot: e773d51 google/parrot/smihandler.c: Use `battery_critical_logged` only with `ELOG_GSMI`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Wed Oct 23 22:34:08 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3987


commit e773d51e9f7988aef065a99d5fece932d6f28ce7
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Oct 21 20:23:35 2013 +0200

    google/parrot/smihandler.c: Use `battery_critical_logged` only with `ELOG_GSMI`
    Removing `-Wno-unused-but-set-variable` from `CFLAGS` results in the
    following error.
    	    CC         mainboard/google/parrot/smihandler.smm.o
    	src/mainboard/google/parrot/smihandler.c: In function 'mainboard_smi_ec':
    	src/mainboard/google/parrot/smihandler.c:97:13: error: variable 'battery_critical_logged' set but not used [-Werror=unused-but-set-variable]
    	cc1: all warnings being treated as errors
    As the variable is only used, when the Kconfig variable `ELOG_GSMI` is
    not zero, only declare and set it in that case.
    Change-Id: I2ef291d2f3e7d35545014e03ba8e0045da6050e5
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/mainboard/google/parrot/smihandler.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c
index a5f6ba2..ec2c9ea 100644
--- a/src/mainboard/google/parrot/smihandler.c
+++ b/src/mainboard/google/parrot/smihandler.c
@@ -94,7 +94,9 @@ static u8 mainboard_smi_ec(void)
 	u8 src;
 	u32 pm1_cnt;
 	static int battery_critical_logged;
 	src = ec_kbc_read_ob();
@@ -106,8 +108,8 @@ static u8 mainboard_smi_ec(void)
 		if (!battery_critical_logged)
 		battery_critical_logged = 1;
 	case EC_LID_CLOSE:

More information about the coreboot-gerrit mailing list