[coreboot-gerrit] New patch to review for coreboot: b2f574e northbridge: i945: Native VGA init: use UMA address

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Sun Oct 27 22:33:22 CET 2013

Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4000


commit b2f574e4dc0e538346127e6e93641f9c796b11e2
Author: Peter Stuge <peter at stuge.se>
Date:   Sat Jun 8 01:25:43 2013 +0200

    northbridge: i945: Native VGA init: use UMA address
    The patch was made by Peter Stuge, I just splitted it
      and added a commit message.
    Change-Id: I4e88c26b70ea8cb249d7613c749b3edc5e3b5e7f
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
 src/northbridge/intel/i945/gma.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 50e07f0..32fa9b4 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -52,14 +52,13 @@ static void gma_func0_init(struct device *dev)
 	/* This should probably run before post VBIOS init. */
 	printk(BIOS_SPEW, "Initializing VGA without OPROM.\n");
-	u32 iobase, mmiobase, physbase, graphics_base;
+	u32 iobase, mmiobase, graphics_base;
 	iobase = dev->resource_list[1].base;
 	mmiobase = dev->resource_list[0].base;
-	physbase = pci_read_config32(dev, 0x5c) & ~0xf;
 	graphics_base = dev->resource_list[2].base + 0x20000;
 	int i915lightup(u32 physbase, u32 iobase, u32 mmiobase, u32 gfx);
-	i915lightup(physbase, iobase, mmiobase, graphics_base);
+	i915lightup(uma_memory_base, iobase, mmiobase, graphics_base);

More information about the coreboot-gerrit mailing list