[coreboot-gerrit] New patch to review for coreboot: 5c82ca5 Fix redefinition of typedef error in gcc 4.5.

Wei Hu (wei@aristanetworks.com) gerrit at coreboot.org
Fri Sep 20 12:53:50 CEST 2013

Wei Hu (wei at aristanetworks.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3931


commit 5c82ca5be8de8c3729d71f9fbfd8de882b4176e0
Author: Wei Hu <wei at aristanetworks.com>
Date:   Fri Sep 20 03:47:02 2013 -0700

    Fix redefinition of typedef error in gcc 4.5.
    This was not legal in C99 but is now allowed in C11.
    Include two header files to bring in typedef pci_devfn_t.
    Tested with and without CONFIG_USBDEBUG.
    Change-Id: I72ac1d2227897a806739be4808bc999956da2d41
    Signed-off-by: Wei Hu <wei at aristanetworks.com>
 src/include/usbdebug.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/include/usbdebug.h b/src/include/usbdebug.h
index 926d658..0d5d8de 100644
--- a/src/include/usbdebug.h
+++ b/src/include/usbdebug.h
@@ -24,7 +24,9 @@
 #define EHCI_BAR_INDEX		0x10
 #define PCI_EHCI_CLASSCODE 	0x0c0320	/* USB2.0 with EHCI controller */
-typedef u32 pci_devfn_t;
+#include <arch/io.h>
+#include <device/device.h>
 pci_devfn_t pci_ehci_dbg_dev(unsigned hcd_idx);
 unsigned long pci_ehci_base_regs(pci_devfn_t dev);
 void pci_ehci_dbg_set_port(pci_devfn_t dev, unsigned int port);

More information about the coreboot-gerrit mailing list