[coreboot-gerrit] Patch merged into coreboot/master: dd6c4ec libpayload: Remove unnecessary keyboard mode setting code

gerrit at coreboot.org gerrit at coreboot.org
Tue Sep 24 01:23:18 CEST 2013

the following patch was just integrated into master:
commit dd6c4ec1ed64f3d9803cca6eb53fa5049cacdd09
Author: Shawn Nematbakhsh <shawnn at chromium.org>
Date:   Fri Aug 23 14:12:24 2013 -0700

    libpayload: Remove unnecessary keyboard mode setting code
    keyboard_init attempts to read the existing mode register, set the
    'XLATE' bit, and write it back. The implementation is buggy because the
    keyboard may be active at the time we read the mode, and we can
    misinterpret scancode data as the reply to our command. It leads to
    problems where the KB gets disabled in firmware.
    In fact, setting the 'XLATE' bit is completely unnecessary, even if we
    desire QEMU keyboard support. We already set this bit when we initialize
    the keyboard in pc_keyboard_init. Basically, this code does nothing
    (or worse), so just remove it.
    Change-Id: Iab23f03fa8bced74842c33a7d263de5f449bb983
    Signed-off-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Reviewed-on: http://review.coreboot.org/3883
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

See http://review.coreboot.org/3883 for details.


More information about the coreboot-gerrit mailing list