[coreboot-gerrit] Patch set updated for coreboot: ed87352 lint: Use temporary build directory

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Fri Sep 27 10:03:22 CEST 2013

Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3593


commit ed8735201907a2dc7439a8d2698651c61412cefa
Author: Nico Huber <nico.huber at secunet.com>
Date:   Tue Jul 2 16:39:28 2013 +0200

    lint: Use temporary build directory
    `util/lint/lint-stable-002-build-dir-handling` always overwrites your
    current `config.h` and `auto.conf` when the pre-commit hook is run. It
    can be very confusing when your configuration is suddenly broken. So fix
    it by not using the default build directory.
    Change-Id: If2bbc97ac2f12a8203a3769d813386a023f93dd6
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
 util/lint/lint-stable-002-build-dir-handling | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling
index 2dad8a6..03f0b62 100755
--- a/util/lint/lint-stable-002-build-dir-handling
+++ b/util/lint/lint-stable-002-build-dir-handling
@@ -53,9 +53,12 @@ if [ "$MAKE" = "" ]; then
 # prepare a config to use
+TMPOBJ=`mktemp .tmpobj.XXXXXX`
+mkdir -p ${TMPOBJ}
 TMPCONFIG=`mktemp .tmpconfig.XXXXXX`
-$MAKE DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
+$MAKE obj=$TMPOBJ DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
 # look up parent directory
@@ -66,5 +69,5 @@ compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/o
 compare_output "`run_printall /tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
 compare_output "`run_printall /../tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"

More information about the coreboot-gerrit mailing list