[coreboot-gerrit] New patch to review for coreboot: 4b0d7b7 Delay cbfs-file tmpfile generation

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Sep 28 20:57:09 CEST 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3950

-gerrit

commit 4b0d7b713fb601e2e95cee7ba04f79da2e1b9fa1
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Sep 28 20:55:52 2013 +0200

    Delay cbfs-file tmpfile generation
    
    For some file processing in the build process we use temporary files.
    Generate them lazily, so "make printall" doesn't lead to their creation.
    
    Change-Id: I27c2c96bab1420cde774e15d2d6fdcb689ec50b3
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index 69ad3a1..6a39427 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -173,7 +173,7 @@ cbfs-files-handler= \
 			)) \
 		$(if $(tmp-cbfs-method), \
 			$(eval tmp-old-cbfs-file:=$(tmp-cbfs-file)) \
-			$(eval tmp-cbfs-file:=$(shell mkdir -p $(obj)/mainboard/$(MAINBOARDDIR); mktemp $(obj)/mainboard/$(MAINBOARDDIR)/cbfs-file.XXXXXX).out) \
+			$(eval tmp-cbfs-file:=$$(shell mkdir -p $(obj)/mainboard/$(MAINBOARDDIR); mktemp $(obj)/mainboard/$(MAINBOARDDIR)/cbfs-file.XXXXXX).out) \
 			$(call cbfs-files-processor-$(tmp-cbfs-method),$(tmp-old-cbfs-file),$(tmp-cbfs-file))) \
 		$(eval cbfs-files += $(tmp-cbfs-file)|$(2)|$($(2)-type)|$($(2)-compression)|$($(2)-position)) \
 		$(eval $(2)-name:=) \



More information about the coreboot-gerrit mailing list