[coreboot-gerrit] New patch to review for coreboot: a68969f vendorcode/amd/agesa/f14/Makefile.inc: Remove `-mtune` from `AGESA_FLAGS`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Tue Apr 22 00:04:02 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5563

-gerrit

commit a68969f1b11f323c7ac813616236b720550065f2
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Apr 21 23:14:52 2014 +0200

    vendorcode/amd/agesa/f14/Makefile.inc: Remove `-mtune` from `AGESA_FLAGS`
    
    Specifying the same CPU type in the switch `mtune` as in the switch
    `march` does not make any sense.
    
    	-march=k8-sse3 -mtune=k8-sse3
    
    From chapter 3.17.17 of the GCC manual [1]:
    
    	-mtune=cpu-type
    	Tune to cpu-type everything applicable about the generated code,
    	except for the ABI and the set of available instructions. While
    	picking a specific cpu-type schedules things appropriately for
    	that particular chip, the compiler does not generate any code
    	that cannot run on the default machine type unless you use a
    	-march=cpu-type option.
    
    [1] http://gcc.gnu.org/onlinedocs/gcc/i386-and-x86-64-Options.html#i386-and-x86-64-Options
        3.17.17 Intel 386 and AMD x86-64 Options
    
    Change-Id: If51fca03f4137a2937fb6c1ad5dd698c6a3a4d8f
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/vendorcode/amd/agesa/f14/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vendorcode/amd/agesa/f14/Makefile.inc b/src/vendorcode/amd/agesa/f14/Makefile.inc
index f457277..2e7853c 100644
--- a/src/vendorcode/amd/agesa/f14/Makefile.inc
+++ b/src/vendorcode/amd/agesa/f14/Makefile.inc
@@ -62,7 +62,7 @@ AGESA_INC += -I$(AGESA_ROOT)/Proc/Recovery/GNB
 AGESA_INC += -I$(AGESA_ROOT)/Proc/Recovery/CPU
 AGESA_INC += -I$(AGESA_ROOT)/Proc/Recovery/Mem
 
-AGESA_CFLAGS =-march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
+AGESA_CFLAGS =-march=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing
 
 export AGESA_ROOT := $(AGESA_ROOT)
 export AGESA_INC  := $(AGESA_INC)



More information about the coreboot-gerrit mailing list