[coreboot-gerrit] Patch set updated for coreboot: 162141d lenovo/t530: Use GPIO defines specified in bd82x6x/pch.h header

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sat Aug 2 02:20:40 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6435

-gerrit

commit 162141df66dc34b57a6ac352e05a0c7e2d44477d
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Aug 1 20:29:40 2014 +1000

    lenovo/t530: Use GPIO defines specified in bd82x6x/pch.h header
    
    Use defines of offsets rather than hard coded values.
    
    Change-Id: Id2471cd22aa402d74163473e48f86af9789cdaa7
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/lenovo/t530/romstage.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/lenovo/t530/romstage.c b/src/mainboard/lenovo/t530/romstage.c
index d65031a..fa4356a 100644
--- a/src/mainboard/lenovo/t530/romstage.c
+++ b/src/mainboard/lenovo/t530/romstage.c
@@ -182,16 +182,17 @@ void main(unsigned long bist)
 	pci_write_config8(PCH_LPC_DEV, GPIO_CNTL, 0x10);
 
 //	setup_pch_gpios(&t530_gpio_map);
-	outl(0x3962a5ff, DEFAULT_GPIOBASE);
-	outl(0x8ebf6aff, DEFAULT_GPIOBASE + 4);
-	outl(0x66917ebb, DEFAULT_GPIOBASE + 0xc);
-	outl(0x00002002, DEFAULT_GPIOBASE + 0x2c);
-	outl(0x02ff08fe, DEFAULT_GPIOBASE + 0x30);
-	outl(0x1f47f7fd, DEFAULT_GPIOBASE + 0x34);
-	outl(0xffbeff43, DEFAULT_GPIOBASE + 0x38);
-	outl(0x000000ff, DEFAULT_GPIOBASE + 0x40);
-	outl(0x00000fff, DEFAULT_GPIOBASE + 0x44);
-	outl(0x00000f4f, DEFAULT_GPIOBASE + 0x48);
+	/* ICH7 GPIOBASE */
+	outl(0x3962a5ff, DEFAULT_GPIOBASE + GPIO_USE_SEL);
+	outl(0x8ebf6aff, DEFAULT_GPIOBASE + GP_IO_SEL);
+	outl(0x66917ebb, DEFAULT_GPIOBASE + GP_LVL);
+	outl(0x00002002, DEFAULT_GPIOBASE + GPI_INV);
+	outl(0x02ff08fe, DEFAULT_GPIOBASE + GPIO_USE_SEL2);
+	outl(0x1f47f7fd, DEFAULT_GPIOBASE + GP_IO_SEL2);
+	outl(0xffbeff43, DEFAULT_GPIOBASE + GP_LVL2);
+	outl(0x000000ff, DEFAULT_GPIOBASE + GPIO_USE_SEL3);
+	outl(0x00000fff, DEFAULT_GPIOBASE + GP_IO_SEL3);
+	outl(0x00000f4f, DEFAULT_GPIOBASE + GPIO_LVL3);
 
 	/* Initialize console device(s) */
 	console_init();



More information about the coreboot-gerrit mailing list