[coreboot-gerrit] New patch to review for coreboot: 08231d9 util/sconfig/main.c: Remove assigned but unused variable `link`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Aug 4 08:27:01 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6488

-gerrit

commit 08231d9b132a8e1452ef63ec80b47f95ca7b1e00
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Aug 4 08:25:05 2014 +0200

    util/sconfig/main.c: Remove assigned but unused variable `link`
    
    Cppcheck 1.65 report the style style issue below.
    
    	[main.c:434]: (style) Variable 'link' is assigned a value that is never used.
    
    So remove the variable `link` as it is not needed.
    
    Change-Id: Ib77b80b74a70985a76eaa3247c4a43832ef23a59
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 util/sconfig/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/util/sconfig/main.c b/util/sconfig/main.c
index 90ceda2..cd15d73 100644
--- a/util/sconfig/main.c
+++ b/util/sconfig/main.c
@@ -431,7 +431,6 @@ static void pass1(FILE *fil, struct device *ptr)
 		if (ptr->rescnt > 0) {
 			fprintf(fil, "\t.resource_list = &%s_res[0],\n", ptr->name);
 		}
-		int link = 0;
 		if (ptr->children || ptr->multidev)
 			fprintf(fil, "\t.link_list = &%s_links[0],\n", ptr->name);
 		else



More information about the coreboot-gerrit mailing list