[coreboot-gerrit] New patch to review for coreboot: 3c94e97 Exynos 5420: skip the EDID read if there is already an EDID.

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Thu Aug 7 00:02:07 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6514

-gerrit

commit 3c94e97abdee585b8b6489baaeb4f172f3ba6b0c
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Tue Aug 27 14:06:19 2013 -0700

    Exynos 5420: skip the EDID read if there is already an EDID.
    
    For many boards, the EDID is known and is set in the ramstage. Reading
    the EDID is slow and if we have it we do not want to reread it.
    
    If the raw_edid struct member is non-null, skip reading the EDID.
    
    Change-Id: I63fb11aa90b2f739a351cdc3209faac2713ea451
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
    Reviewed-on: https://chromium-review.googlesource.com/167116
    Reviewed-by: Gabe Black <gabeblack at google.com>
    Tested-by: ron minnich <rminnich at chromium.org>
    Commit-Queue: Ronald Minnich <rminnich at google.com>
    (cherry picked from commit 80f48655570de544a7e1939c4f5f28713f11d829)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/cpu/samsung/exynos5420/dp.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/cpu/samsung/exynos5420/dp.c b/src/cpu/samsung/exynos5420/dp.c
index 59a4647..b6f83b6 100644
--- a/src/cpu/samsung/exynos5420/dp.c
+++ b/src/cpu/samsung/exynos5420/dp.c
@@ -241,10 +241,15 @@ static unsigned int exynos_dp_handle_edid(struct edp_device_info *edp_info)
 		return -1;
 	}
 
-	ret = exynos_dp_read_edid();
-	if (ret != EXYNOS_DP_SUCCESS) {
-		printk(BIOS_ERR, "DP exynos_dp_read_edid() failed\n");
-		return -1;
+	if (edp_info->raw_edid){
+		ret = EXYNOS_DP_SUCCESS;
+		printk(BIOS_SPEW, "EDID compiled in, skipping read\n");
+	} else {
+		ret = exynos_dp_read_edid();
+		if (ret != EXYNOS_DP_SUCCESS) {
+			printk(BIOS_ERR, "DP exynos_dp_read_edid() failed\n");
+			return -1;
+		}
 	}
 
 	return ret;



More information about the coreboot-gerrit mailing list