[coreboot-gerrit] New patch to review for coreboot: d3835cb chromeec: Implement full battery workaround at 6%

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Thu Aug 7 19:57:56 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6521

-gerrit

commit d3835cb8c45a5e9ac23cf5f1eed444462a10ba13
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Sep 16 14:22:57 2013 -0700

    chromeec: Implement full battery workaround at 6%
    
    Currently the workaround for indicating a "full" battery kicks
    in at 3%, but this turns out to be too high for some devices.
    So move the workaround start point to 6% from full, or 94%.
    
    Change-Id: Ib4305df3a68e89f3a10a096d0e89d8105ea9037b
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/169549
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit 982dc496a0553c90dee56fda6411b7c21a5d7da9)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/ec/google/chromeec/acpi/battery.asl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl
index 341911c..2ef1199 100644
--- a/src/ec/google/chromeec/acpi/battery.asl
+++ b/src/ec/google/chromeec/acpi/battery.asl
@@ -210,8 +210,8 @@ Device (BAT0)
 			// https://bugzilla.kernel.org/show_bug.cgi?id=12632
 			Store (BTDF, Local2)
 
-			// See if within ~3% of full
-			ShiftRight (Local2, 5, Local3)
+			// See if within ~6% of full
+			ShiftRight (Local2, 4, Local3)
 			If (LAnd (LGreater (Local1, Subtract (Local2, Local3)),
 			          LLess (Local1, Add (Local2, Local3))))
 			{



More information about the coreboot-gerrit mailing list