[coreboot-gerrit] New patch to review for coreboot: 83d4d9a cbfstool: fix option parsing

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Aug 9 17:45:39 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6564

-gerrit

commit 83d4d9a4762be3bcff667500d26071ecd3ee3fcb
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Aug 9 17:44:39 2014 +0200

    cbfstool: fix option parsing
    
    "cbfstool create -B bootblock -s size" (in this order)
    would break bootblock selection.
    
    Change-Id: I9a9f5660827c8bf60dae81b519c6f026f3aaa0f3
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 util/cbfstool/cbfstool.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 73b1cf0..f236d8b 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -671,6 +671,7 @@ int main(int argc, char **argv)
 				if (tolower(suffix[0])=='m') {
 					param.size *= 1024 * 1024;
 				}
+				break;
 			case 'B':
 				param.bootblock = optarg;
 				break;



More information about the coreboot-gerrit mailing list