[coreboot-gerrit] Patch merged into coreboot/master: ad4556f exynos5420: Make USB A-A booting work with early data cache

gerrit at coreboot.org gerrit at coreboot.org
Tue Aug 12 22:01:15 CEST 2014


the following patch was just integrated into master:
commit ad4556f2cb429d921a9e00e3937797ea6f6f4cd8
Author: Julius Werner <jwerner at chromium.org>
Date:   Wed Aug 21 17:33:31 2013 -0700

    exynos5420: Make USB A-A booting work with early data cache
    
    Apparently the IROM doesn't like data caches... the recently added
    dcache-in-bootblock makes A-A booting fail, and flushes/invalidations
    alone don't seem to fix it. It's pretty fast anyway, so we just disable
    the cache again for the duration of the IROM call.
    
    Also removes a superfluous invalidation line from the bootblock code...
    dcache_mmu_enable/disable already take care of that.
    
    Old-Change-Id: I35580d15664c7b4197d4ed14028720147adbf918
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/66602
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit e9c28a6a7a88c8286e62764ee5ad2694da2e822f)
    
    exynos5: Implement booting from SDMMC media
    
    This patch augments the alternative CBFS media source implementation for
    Exynos5250 and Exynos5420 to allow booting from SDMMC devices (such as
    an SD or uSD card reader, if available). It also moves MMC
    initialization for the Snow, Pit and Kirby boards from romstage to
    ramstage (mainboard_init) to prevent it from interfering with the IROM
    during SDMMC boot.
    
    Old-Change-Id: Ic4adef80c28262d084a53c28ec59aa7ac3af50c8
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/66154
    (cherry picked from commit 08de13b72432c076e3327c048df93d89d52b0ecc)
    
    snow and pit: turn on FET4 (for SD card) at bootup
    
    Explictly enable FET4 on Snow and Pit.
    
    Historically we haven't needed to do this because:
    * On snow there's a bypass around FET4 which effectively eliminates
      it.  Even if we don't turn on FET4 the SD card is still powered.
      Turning on FET4 doesn't hurt though and is technically correct.
    * On pit the EC turns on FET4 on cold bootup.
    
    On pit we run into a problem if the kernel turns off FET4 like in
    <https://gerrit.chromium.org/gerrit/#/c/65332/> and then we get a
    software reset or warm reset.  In this case the EC won't know to turn
    it back on.
    
    This was ported from: https://gerrit.chromium.org/gerrit/#/c/65673
    
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    
    Old-Change-Id: I57337f12b38889e6afee8577cf8807ec4c41e91c
    Reviewed-on: https://gerrit.chromium.org/gerrit/66786
    Commit-Queue: David Hendricks <dhendrix at chromium.org>
    Tested-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    (cherry picked from commit e910117047d898b6b1d0dc965ef2ec0237d17646)
    
    Squashed three commits for alternate cbfs SD support.
    
    Change-Id: Idbd1fd4776cbf8cb20d03e6b691104cd8540a1ec
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
    Reviewed-on: http://review.coreboot.org/6530
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/6530 for details.

-gerrit



More information about the coreboot-gerrit mailing list