[coreboot-gerrit] New patch to review for coreboot: bab8a40 board_status: Collect cbmem console even if serial is available since serial is probably broken.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sat Aug 23 01:22:06 CEST 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6746

-gerrit

commit bab8a408d96540c3cc2c75f941917cb604925ff0
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Fri Aug 22 23:41:35 2014 +0200

    board_status: Collect cbmem console even if serial is available since serial is probably broken.
    
    Change-Id: Ic7c90a99e3175138431cbfc4f91e70154265f452
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 util/board_status/board_status.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 49d2c73..0659d24 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -246,14 +246,14 @@ printf "Upstream revision: %s\n" $($getrevision -u) >> ${tmpdir}/${results}/revi
 printf "Upstream URL: %s\n" $($getrevision -U)>> ${tmpdir}/${results}/revision.txt
 printf "Timestamp: %s\n" "$timestamp" >> ${tmpdir}/${results}/revision.txt
 
-if [ -z "$SERIAL_DEVICE" ]; then
-	test_cmd $REMOTE "cbmem"
-	cmd $REMOTE "cbmem -c" "${tmpdir}/${results}/coreboot_console.txt"
-	cmd_nonfatal $REMOTE "cbmem -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
-else
-	get_serial_bootlog "$SERIAL_DEVICE" "$SERIAL_PORT_SPEED" "${tmpdir}/${results}/coreboot_console.txt"
+if [ -n "$SERIAL_DEVICE" ]; then
+	get_serial_bootlog "$SERIAL_DEVICE" "$SERIAL_PORT_SPEED" "${tmpdir}/${results}/serial_console.txt"
 fi
 
+test_cmd $REMOTE "cbmem"
+cmd $REMOTE "cbmem -c" "${tmpdir}/${results}/coreboot_console.txt"
+cmd_nonfatal $REMOTE "cbmem -t" "${tmpdir}/${results}/coreboot_timestamps.txt"
+
 cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
 
 #



More information about the coreboot-gerrit mailing list