[coreboot-gerrit] New patch to review for coreboot: 7f09ed5 ec/lenovo/h8: Rename LED to avoid conflicting with thinkpad-acpi

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Thu Aug 28 01:55:05 CEST 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6789

-gerrit

commit 7f09ed5253a741d17383a3e071f78e1475661da7
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Thu Aug 28 01:31:33 2014 +0200

    ec/lenovo/h8: Rename LED to avoid conflicting with thinkpad-acpi
    
    Change-Id: I9fd7f894d0e611f61e8702e4eacb12d7b81154d8
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/arch/x86/boot/smbios.c             |  2 +-
 src/ec/lenovo/h8/acpi/ec.asl           |  2 +-
 src/ec/lenovo/h8/acpi/systemstatus.asl | 32 ++++++++++++++++----------------
 3 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/arch/x86/boot/smbios.c b/src/arch/x86/boot/smbios.c
index 9eea38f..8437fb5 100644
--- a/src/arch/x86/boot/smbios.c
+++ b/src/arch/x86/boot/smbios.c
@@ -253,7 +253,7 @@ static int smbios_write_type3(unsigned long *current, int handle)
 	t->bootup_state = SMBIOS_STATE_SAFE;
 	t->power_supply_state = SMBIOS_STATE_SAFE;
 	t->thermal_state = SMBIOS_STATE_SAFE;
-	t->_type = SMBIOS_ENCLOSURE_NOTEBOOK;
+	t->_type = SMBIOS_ENCLOSURE_DESKTOP;
 	t->security_status = SMBIOS_STATE_SAFE;
 	len = t->length + smbios_string_table_len(t->eos);
 	*current += len;
diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl
index e8d5215..28f095c 100644
--- a/src/ec/lenovo/h8/acpi/ec.asl
+++ b/src/ec/lenovo/h8/acpi/ec.asl
@@ -70,7 +70,7 @@ Device(EC)
 		Return (ECMD)
 	}
 
-	Method (LED, 1, NotSerialized)
+	Method (TLED, 1, NotSerialized)
 	{
 		Store(Arg0, LEDS)
 	}
diff --git a/src/ec/lenovo/h8/acpi/systemstatus.asl b/src/ec/lenovo/h8/acpi/systemstatus.asl
index 17e8ba7..c51a4fa 100644
--- a/src/ec/lenovo/h8/acpi/systemstatus.asl
+++ b/src/ec/lenovo/h8/acpi/systemstatus.asl
@@ -27,37 +27,37 @@ Scope (\_SI)
 		If (LEqual (Arg0, 0)) {
 			/* Indicator off */
 
-			/* power LED off */
-			\_SB.PCI0.LPCB.EC.LED(0x00)
-			/* suspend LED off */
-			\_SB.PCI0.LPCB.EC.LED(0x07)
+			/* power TLED off */
+			\_SB.PCI0.LPCB.EC.TLED(0x00)
+			/* suspend TLED off */
+			\_SB.PCI0.LPCB.EC.TLED(0x07)
 		}
 
 		If (LEqual (Arg0, 1)) {
 			/* working state */
 
-			/* power LED on */
-			\_SB.PCI0.LPCB.EC.LED(0x80)
-			/* suspend LED off */
-			\_SB.PCI0.LPCB.EC.LED(0x07)
+			/* power TLED on */
+			\_SB.PCI0.LPCB.EC.TLED(0x80)
+			/* suspend TLED off */
+			\_SB.PCI0.LPCB.EC.TLED(0x07)
 		}
 
 		If (LEqual (Arg0, 2)) {
 			/* waking state */
 
-			/* power LED om */
-			\_SB.PCI0.LPCB.EC.LED(0x80)
-			/* suspend LED blinking */
-			\_SB.PCI0.LPCB.EC.LED(0xc7)
+			/* power TLED om */
+			\_SB.PCI0.LPCB.EC.TLED(0x80)
+			/* suspend TLED blinking */
+			\_SB.PCI0.LPCB.EC.TLED(0xc7)
 		}
 
 		If (LEqual (Arg0, 3)) {
 			/* sleep state */
 
-			/* power LED off */
-			\_SB.PCI0.LPCB.EC.LED(0x00)
-			/* suspend LED on */
-			\_SB.PCI0.LPCB.EC.LED(0x87)
+			/* power TLED off */
+			\_SB.PCI0.LPCB.EC.TLED(0x00)
+			/* suspend TLED on */
+			\_SB.PCI0.LPCB.EC.TLED(0x87)
 		}
 	}
 }



More information about the coreboot-gerrit mailing list