[coreboot-gerrit] New patch to review for coreboot: dc3353a arm: Update a stale comment in bootblock .S files

Isaac Christensen (isaac.christensen@se-eng.com) gerrit at coreboot.org
Thu Aug 28 02:00:32 CEST 2014


Isaac Christensen (isaac.christensen at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6791

-gerrit

commit dc3353aa289e0d33d04016f29189825aec8efadf
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu Oct 3 14:02:45 2013 -0700

    arm: Update a stale comment in bootblock .S files
    
    This just updates a comment which refers to "board_init_f". We use
    bootblock main() in coreboot.
    
    Change-Id: I4cb6b3c11f163b67fe48de495d13dce88710efc0
    Reviewed-on: https://chromium-review.googlesource.com/172095
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Commit-Queue: David Hendricks <dhendrix at chromium.org>
    Tested-by: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit 65139f29682cedca8dfb58b3dfe67eab64299064)
    Signed-off-by: Isaac Christensen <isaac.christensen at se-eng.com>
---
 src/arch/arm/armv4/bootblock.S          | 2 +-
 src/arch/arm/armv7/bootblock.S          | 2 +-
 src/soc/nvidia/tegra124/bootblock_asm.S | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/arch/arm/armv4/bootblock.S b/src/arch/arm/armv4/bootblock.S
index 5f7de13..3ba2a88 100644
--- a/src/arch/arm/armv4/bootblock.S
+++ b/src/arch/arm/armv4/bootblock.S
@@ -65,7 +65,7 @@ init_stack_loop:
 	cmp	r0, r1
 	bne	init_stack_loop
 
-/* Set stackpointer in internal RAM to call board_init_f */
+/* Set stackpointer in internal RAM to call bootblock main() */
 call_bootblock:
 	ldr	sp, .Stack /* Set up stack pointer */
 	ldr	r0,=0x00000000
diff --git a/src/arch/arm/armv7/bootblock.S b/src/arch/arm/armv7/bootblock.S
index f2f528a..f18a355 100644
--- a/src/arch/arm/armv7/bootblock.S
+++ b/src/arch/arm/armv7/bootblock.S
@@ -76,7 +76,7 @@ init_stack_loop:
 	cmp	r0, r1
 	bne	init_stack_loop
 
-/* Set stackpointer in internal RAM to call board_init_f */
+/* Set stackpointer in internal RAM to call bootblock main() */
 call_bootblock:
 	ldr	sp, .Stack /* Set up stack pointer */
 	ldr	r0,=0x00000000
diff --git a/src/soc/nvidia/tegra124/bootblock_asm.S b/src/soc/nvidia/tegra124/bootblock_asm.S
index 5f7de13..3ba2a88 100644
--- a/src/soc/nvidia/tegra124/bootblock_asm.S
+++ b/src/soc/nvidia/tegra124/bootblock_asm.S
@@ -65,7 +65,7 @@ init_stack_loop:
 	cmp	r0, r1
 	bne	init_stack_loop
 
-/* Set stackpointer in internal RAM to call board_init_f */
+/* Set stackpointer in internal RAM to call bootblock main() */
 call_bootblock:
 	ldr	sp, .Stack /* Set up stack pointer */
 	ldr	r0,=0x00000000



More information about the coreboot-gerrit mailing list