[coreboot-gerrit] New patch to review for coreboot: 6e84306 ddr3: Plumber DIMM type to parsed structure.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Dec 7 14:00:31 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7686

-gerrit

commit 6e843066a1b206eeff4c2fc7413e2b4cde1d6f4a
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Dec 7 13:56:48 2014 +0100

    ddr3: Plumber DIMM type to parsed structure.
    
    Useful for distinguishing registered modules.
    
    Change-Id: Ibf4a0f2cde6d50a1c5c1da0f50e3022a2bc7ccd7
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/device/dram/ddr3.c         | 1 +
 src/include/device/dram/ddr3.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c
index 00f2ba9..86abea8 100644
--- a/src/device/dram/ddr3.c
+++ b/src/device/dram/ddr3.c
@@ -126,6 +126,7 @@ int spd_decode_ddr3(dimm_attr * dimm, spd_raw_data spd)
 		return SPD_STATUS_INVALID;
 	}
 	dimm->dram_type = SPD_MEMORY_TYPE_SDRAM_DDR3;
+	dimm->dimm_type = spd[3] & 0xf;
 
 	crc = spd_ddr3_calc_crc(spd, sizeof(*spd));
 	/* Compare with the CRC in the SPD */
diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h
index ef0d0ec..10924a2 100644
--- a/src/include/device/dram/ddr3.h
+++ b/src/include/device/dram/ddr3.h
@@ -135,6 +135,7 @@ typedef union dimm_flags_st {
  */
 typedef struct dimm_attr_st {
 	enum spd_memory_type dram_type;
+	enum spd_dimm_type dimm_type;
 	u16 cas_supported;
 	/* Flags extracted from SPD */
 	dimm_flags_t flags;



More information about the coreboot-gerrit mailing list