[coreboot-gerrit] New patch to review for coreboot: c6fe522 mainboard/{iwill, amd/serenget_*}: Cast ptr as we discard const qualifier

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sun Dec 7 17:46:07 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7693

-gerrit

commit c6fe52220b6fb0df04d0f61df7b32d50edd228c1
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon Dec 8 03:43:44 2014 +1100

    mainboard/{iwill,amd/serenget_*}: Cast ptr as we discard const qualifier
    
    This silences a useless Clang warn in this case.
    
    Change-Id: I22e55eb2b7fe06c416e5e4fd322045bc7031ed63
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/amd/serengeti_cheetah/acpi_tables.c       | 6 +++---
 src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c | 8 ++++----
 src/mainboard/iwill/dk8_htx/acpi_tables.c               | 8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/mainboard/amd/serengeti_cheetah/acpi_tables.c b/src/mainboard/amd/serengeti_cheetah/acpi_tables.c
index 65b8fc5..e171db5 100644
--- a/src/mainboard/amd/serengeti_cheetah/acpi_tables.c
+++ b/src/mainboard/amd/serengeti_cheetah/acpi_tables.c
@@ -154,13 +154,13 @@ unsigned long mainboard_write_acpi_tables(unsigned long start, acpi_rsdp_t *rsdp
 		ssdtx = (acpi_header_t *)current;
 		switch(sysconf.hcid[i]) {
 		case 1: //8132
-			p = &AmlCode_ssdt2;
+			p = (void *) &AmlCode_ssdt2;
 			break;
 		case 2: //8151
-			p = &AmlCode_ssdt3;
+			p = (void *) &AmlCode_ssdt3;
 			break;
 		case 3: //8131
-			p = &AmlCode_ssdt4;
+			p = (void *) &AmlCode_ssdt4;
 			break;
 		default:
 			continue;
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
index ea3ec6c..5a1b0d1 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c
@@ -162,17 +162,17 @@ unsigned long mainboard_write_acpi_tables(unsigned long current,
 		ssdtx = (acpi_header_t *)current;
 		switch(sysconf.hcid[i]) {
 		case 1:
-			p = &AmlCode_ssdt2;
+			p = (void *) &AmlCode_ssdt2;
 			break;
 		case 2:
-			p = &AmlCode_ssdt3;
+			p = (void *) &AmlCode_ssdt3;
 			break;
 		case 3: //8131
-			p = &AmlCode_ssdt4;
+			p = (void *) &AmlCode_ssdt4;
 			break;
 		default:
 			//HTX no io apic
-			p = &AmlCode_ssdt5;
+			p = (void *) &AmlCode_ssdt5;
 		}
 		memcpy(ssdtx, p, sizeof(acpi_header_t));
 		current += ssdtx->length;
diff --git a/src/mainboard/iwill/dk8_htx/acpi_tables.c b/src/mainboard/iwill/dk8_htx/acpi_tables.c
index 53e79b0..85d9862 100644
--- a/src/mainboard/iwill/dk8_htx/acpi_tables.c
+++ b/src/mainboard/iwill/dk8_htx/acpi_tables.c
@@ -159,17 +159,17 @@ unsigned long mainboard_write_acpi_tables(unsigned long start, acpi_rsdp_t *rsdp
                 ssdtx = (acpi_header_t *)current;
                 switch(sysconf.hcid[i]) {
                 case 1: //8132
-                        p = &AmlCode_ssdt2;
+                        p = (void *) &AmlCode_ssdt2;
                         break;
                 case 2: //8151
-                        p = &AmlCode_ssdt3;
+                        p = (void *) &AmlCode_ssdt3;
                         break;
 		case 3: //8131
-                        p = &AmlCode_ssdt4;
+                        p = (void *) &AmlCode_ssdt4;
                         break;
                 default:
 			//HTX no io apic
-                        p = &AmlCode_ssdt5;
+                        p = (void *) &AmlCode_ssdt5;
 			break;
                 }
 		memcpy(ssdtx, p, sizeof(acpi_header_t));



More information about the coreboot-gerrit mailing list