[coreboot-gerrit] New patch to review for coreboot: 4feb213 include/cpu/amd/{gx2, lx}def.h: Treat magic const as 'ull' type

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sun Dec 7 18:35:33 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7695

-gerrit

commit 4feb2132433fc239c5dba0fa8b346de57cc37da7
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon Dec 8 04:34:08 2014 +1100

    include/cpu/amd/{gx2,lx}def.h: Treat magic const as 'ull' type
    
    Avoids clang warn.
    
    Change-Id: Icc4a3b62095a57ae77bb9f90369279608019e6aa
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/include/cpu/amd/gx2def.h | 2 +-
 src/include/cpu/amd/lxdef.h  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/include/cpu/amd/gx2def.h b/src/include/cpu/amd/gx2def.h
index beb4c65..587cce1 100644
--- a/src/include/cpu/amd/gx2def.h
+++ b/src/include/cpu/amd/gx2def.h
@@ -483,7 +483,7 @@
 #define GLIU1_IOD_SC_5		(MSR_GLIU1 + 0xE8)
 
 /* definitions that are "once you are mostly up, start VSA" type things */
-#define SMM_OFFSET		0x40400000
+#define SMM_OFFSET		0x40400000ull
 #define SMM_SIZE		128		/* changed SMM_SIZE from 256 KB to 128 KB */
 #define DMM_OFFSET		0x0C0000000
 #define DMM_SIZE		128
diff --git a/src/include/cpu/amd/lxdef.h b/src/include/cpu/amd/lxdef.h
index da26895..821dae8 100644
--- a/src/include/cpu/amd/lxdef.h
+++ b/src/include/cpu/amd/lxdef.h
@@ -620,7 +620,7 @@
 
 /* ------------------------  */
 
-#define SMM_OFFSET	0x80400000	/* above 2GB */
+#define SMM_OFFSET	0x80400000ull	/* above 2GB */
 #define SMM_SIZE	128			/* changed SMM_SIZE from 256 KB to 128 KB */
 
 /* DRAM_TERMINATED affects how the DELAY register is set. */



More information about the coreboot-gerrit mailing list