[coreboot-gerrit] Patch set updated for coreboot: 9b04d66 vendorcode/amd/agesa/f1{5, 5tn, 6kb}: Silence empty loop warn

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sun Dec 7 21:40:29 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7688

-gerrit

commit 9b04d665ccae3e7a5914eaea05683b4f4564b73d
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon Dec 8 01:00:43 2014 +1100

    vendorcode/amd/agesa/f1{5,5tn,6kb}: Silence empty loop warn
    
    Add decorations to specify that empty loop is intended so.
    
    Change-Id: Ia3e40d341eca5e26da3832edc733cf1ccc96c136
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Found-by: Clang
---
 src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c   | 5 ++++-
 src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c | 5 ++++-
 src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c b/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
index 20ba2a5..6575b6f 100644
--- a/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
+++ b/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
@@ -507,7 +507,10 @@ MemFGetPCI (
   UINT8 Die;
 
   // Find NBBlock that associates with node NodeID
-  for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++);
+  for (Die = 0; Die < MAX_NODES_SUPPORTED; Die ++)
+    if (NBPtr[Die].Node = NodeID)
+      break;
+
   ASSERT (Die < MAX_NODES_SUPPORTED);
 
   // Get the northbridge pointer for the targeted node.
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
index 20ba2a5..6575b6f 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
@@ -507,7 +507,10 @@ MemFGetPCI (
   UINT8 Die;
 
   // Find NBBlock that associates with node NodeID
-  for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++);
+  for (Die = 0; Die < MAX_NODES_SUPPORTED; Die ++)
+    if (NBPtr[Die].Node = NodeID)
+      break;
+
   ASSERT (Die < MAX_NODES_SUPPORTED);
 
   // Get the northbridge pointer for the targeted node.
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
index 6bd8521..d1754d1 100644
--- a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
+++ b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c
@@ -507,7 +507,10 @@ MemFGetPCI (
   UINT8 Die;
 
   // Find NBBlock that associates with node NodeID
-  for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++);
+  for (Die = 0; Die < MAX_NODES_SUPPORTED; Die ++)
+    if (NBPtr[Die].Node = NodeID)
+      break;
+
   ASSERT (Die < MAX_NODES_SUPPORTED);
 
   // Get the northbridge pointer for the targeted node.



More information about the coreboot-gerrit mailing list