[coreboot-gerrit] New patch to review for coreboot: 99357a6 soc/intel/fsp_baytrail/romstage/romstage.c: Fix missing entry-point prototype

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Mon Dec 8 11:56:12 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7717

-gerrit

commit 99357a6481a372d948613186299e0fb88efc9b2f
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon Dec 8 21:50:58 2014 +1100

    soc/intel/fsp_baytrail/romstage/romstage.c: Fix missing entry-point prototype
    
    In '-ffreestanding' main() is just as any other function and so
    it needs a type-signature. Fixes a clang warning.
    
    Change-Id: I77dadbf487db3506bb776f044fe456a3e58b8839
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/soc/intel/fsp_baytrail/romstage/romstage.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/soc/intel/fsp_baytrail/romstage/romstage.c b/src/soc/intel/fsp_baytrail/romstage/romstage.c
index 6dff743..a530ee1 100644
--- a/src/soc/intel/fsp_baytrail/romstage/romstage.c
+++ b/src/soc/intel/fsp_baytrail/romstage/romstage.c
@@ -152,6 +152,7 @@ static void baytrail_rtc_init(void)
 }
 
 /* Entry from cache-as-ram.inc. */
+void * asmlinkage main(FSP_INFO_HEADER *fsp_info_header); // XXX: find a better place
 void * asmlinkage main(FSP_INFO_HEADER *fsp_info_header)
 {
 	const unsigned long func_dis = PMC_BASE_ADDRESS + FUNC_DIS;



More information about the coreboot-gerrit mailing list