[coreboot-gerrit] New patch to review for coreboot: 40d4c10 mainboard: Fix correct index variable usage in double loop construct
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Mon Dec 8 12:21:18 CET 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7718
-gerrit
commit 40d4c105a1db30a7a270b18c23164c2a0ae70a42
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Mon Dec 8 22:19:48 2014 +1100
mainboard: Fix correct index variable usage in double loop construct
Change-Id: I672c532c3f7179038d41f269bba434b8703e254b
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Found-by: Clang
---
src/mainboard/amd/dinar/rd890_cfg.c | 2 +-
src/mainboard/supermicro/h8qgi/rd890_cfg.c | 2 +-
src/mainboard/supermicro/h8scm/rd890_cfg.c | 2 +-
src/mainboard/tyan/s8226/rd890_cfg.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mainboard/amd/dinar/rd890_cfg.c b/src/mainboard/amd/dinar/rd890_cfg.c
index 783c130..69c4d41 100644
--- a/src/mainboard/amd/dinar/rd890_cfg.c
+++ b/src/mainboard/amd/dinar/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;
diff --git a/src/mainboard/supermicro/h8qgi/rd890_cfg.c b/src/mainboard/supermicro/h8qgi/rd890_cfg.c
index 9c91920..a5f6650 100644
--- a/src/mainboard/supermicro/h8qgi/rd890_cfg.c
+++ b/src/mainboard/supermicro/h8qgi/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;
diff --git a/src/mainboard/supermicro/h8scm/rd890_cfg.c b/src/mainboard/supermicro/h8scm/rd890_cfg.c
index 9c91920..a5f6650 100644
--- a/src/mainboard/supermicro/h8scm/rd890_cfg.c
+++ b/src/mainboard/supermicro/h8scm/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;
diff --git a/src/mainboard/tyan/s8226/rd890_cfg.c b/src/mainboard/tyan/s8226/rd890_cfg.c
index 9c91920..a5f6650 100644
--- a/src/mainboard/tyan/s8226/rd890_cfg.c
+++ b/src/mainboard/tyan/s8226/rd890_cfg.c
@@ -82,7 +82,7 @@ static void nb_platform_config(device_t nb_dev, AMD_NB_CONFIG *NbConfigPtr)
}
if ((platform_config.PortHotplugMap & (1 << i)) != 0) {
u16 j;
- pPcieConfig->PortConfiguration[j].PortHotplug = ON; /* Enable Hotplug */
+ pPcieConfig->PortConfiguration[i].PortHotplug = ON; /* Enable Hotplug */
/* Set Hotplug descriptor info */
for (j = 0; j < 8; j++) {
u32 PortDescriptor;
More information about the coreboot-gerrit
mailing list