[coreboot-gerrit] Patch set updated for coreboot: b8b3059 nyan*: Reduce the EC SPI bus frequency to 3 MHz.

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Wed Dec 10 02:04:45 CET 2014


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7739

-gerrit

commit b8b3059a112f4b0298b1f6f1b506f95709165d77
Author: Gabe Black <gabeblack at google.com>
Date:   Mon Apr 7 01:19:27 2014 -0700

    nyan*: Reduce the EC SPI bus frequency to 3 MHz.
    
    The EC doesn't seem to be able to handle its bus running at 4 MHz or higher.
    To avoid it not being able to keep up, we reduce the frequency of that bus on
    all nyan derivatives to 3 MHz. Because PLLP can't be divided that low, we
    switch the clock source to CLKM.
    
    BUG=chrome-os-partner:22849
    TEST=Built and booted on nyan.
    BRANCH=None
    
    Original-Change-Id: I8f31b41098d64634427b4686f5333012f643fada
    Original-Signed-off-by: Gabe Black <gabeblack at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/193349
    Original-Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Original-Tested-by: Gabe Black <gabeblack at chromium.org>
    Original-Reviewed-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit c215c50a5bb982b0e671c951e2fe8df06db85db2)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Ia60513d118aed8881927e9d52f170e27655ea8e7
---
 src/mainboard/google/nyan/romstage.c       | 2 +-
 src/mainboard/google/nyan_big/romstage.c   | 2 +-
 src/mainboard/google/nyan_blaze/romstage.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/nyan/romstage.c b/src/mainboard/google/nyan/romstage.c
index eeec9bd..7310cc8 100644
--- a/src/mainboard/google/nyan/romstage.c
+++ b/src/mainboard/google/nyan/romstage.c
@@ -129,7 +129,7 @@ static void setup_pinmux(void)
 
 static void configure_ec_spi_bus(void)
 {
-	clock_configure_source(sbc1, PLLP, 5000);
+	clock_configure_source(sbc1, CLK_M, 3000);
 }
 
 static void configure_tpm_i2c_bus(void)
diff --git a/src/mainboard/google/nyan_big/romstage.c b/src/mainboard/google/nyan_big/romstage.c
index 6327c97..d7cc1bf 100644
--- a/src/mainboard/google/nyan_big/romstage.c
+++ b/src/mainboard/google/nyan_big/romstage.c
@@ -129,7 +129,7 @@ static void setup_pinmux(void)
 
 static void configure_ec_spi_bus(void)
 {
-	clock_configure_source(sbc1, PLLP, 5000);
+	clock_configure_source(sbc1, CLK_M, 3000);
 }
 
 static void configure_tpm_i2c_bus(void)
diff --git a/src/mainboard/google/nyan_blaze/romstage.c b/src/mainboard/google/nyan_blaze/romstage.c
index 6327c97..d7cc1bf 100644
--- a/src/mainboard/google/nyan_blaze/romstage.c
+++ b/src/mainboard/google/nyan_blaze/romstage.c
@@ -129,7 +129,7 @@ static void setup_pinmux(void)
 
 static void configure_ec_spi_bus(void)
 {
-	clock_configure_source(sbc1, PLLP, 5000);
+	clock_configure_source(sbc1, CLK_M, 3000);
 }
 
 static void configure_tpm_i2c_bus(void)



More information about the coreboot-gerrit mailing list