[coreboot-gerrit] New patch to review for coreboot: faa1552 spi: Make idcode debug print more useful

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Wed Dec 10 03:45:42 CET 2014


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7754

-gerrit

commit faa1552b8771236afe5eb629c151bb1237e0a321
Author: David Hendricks <dhendrix at chromium.org>
Date:   Fri Mar 21 19:32:09 2014 -0700

    spi: Make idcode debug print more useful
    
    The old print simply said "Got idcode". This makes it actually
    display what it got.
    
    BUG=none
    BRANCH=none
    TEST=tested on nyan
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    
    Original-Change-Id: I8f1c8fde6e4ac00b12e74f925b7bcff83d1f69f3
    Original-Reviewed-on: https://chromium-review.googlesource.com/191204
    Original-Tested-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Original-Commit-Queue: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit 5f13789be77d038d3c1602037afe29a0351f72ee)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I65d0d51c17b3bda62351532aac1756b630433ea3
---
 src/drivers/spi/spi_flash.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c
index 2750a37..de19b2b 100644
--- a/src/drivers/spi/spi_flash.c
+++ b/src/drivers/spi/spi_flash.c
@@ -285,7 +285,10 @@ struct spi_flash *spi_flash_probe(unsigned int bus, unsigned int cs)
 		goto err_read_id;
 
 #if CONFIG_DEBUG_SPI_FLASH
-	printk(BIOS_SPEW, "SF: Got idcodes\n");
+	printk(BIOS_SPEW, "SF: Got idcode: ");
+	for (i = 0; i < sizeof(idcode); i++)
+		printk(BIOS_SPEW, "%02x ", idcode[i]);
+	printk(BIOS_SPEW, "\n");
 #endif
 
 	/* count the number of continuation bytes */



More information about the coreboot-gerrit mailing list