[coreboot-gerrit] New patch to review for coreboot: bcb1195 Makefile.inc: Prevent passing duplicate obj names to ar

Scott Duplichan (scott@notabs.org) gerrit at coreboot.org
Fri Dec 12 23:43:42 CET 2014


Scott Duplichan (scott at notabs.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7787

-gerrit

commit bcb1195550f5a4e39879c1529270f40e07d35b15
Author: Scott Duplichan <scott at notabs.org>
Date:   Fri Dec 12 15:23:02 2014 -0600

    Makefile.inc: Prevent passing duplicate obj names to ar
    
    For some of the boards using AMD processors, the Agesa Makefile.inc
    is processed twice, causing the list of obj files passed to the ar
    command to be added twice. This does not break the build, but does
    make the ar command line unnecessarily long.
    
    Change-Id: I02a7e6fc617e337ca2e2dceeff3d4db9995bfe16
    Signed-off-by: Scott Duplichan <scott at notabs.org>
---
 src/mainboard/supermicro/h8qgi/Makefile.inc | 2 --
 src/mainboard/supermicro/h8scm/Makefile.inc | 2 --
 src/mainboard/tyan/s8226/Makefile.inc       | 2 --
 3 files changed, 6 deletions(-)

diff --git a/src/mainboard/supermicro/h8qgi/Makefile.inc b/src/mainboard/supermicro/h8qgi/Makefile.inc
index 9a4d419..de13679 100644
--- a/src/mainboard/supermicro/h8qgi/Makefile.inc
+++ b/src/mainboard/supermicro/h8qgi/Makefile.inc
@@ -32,5 +32,3 @@ CIMX_PREFIX ?= $(src)/vendorcode/amd/cimx
 AGESA_ROOT ?= $(AGESA_PREFIX)/f15
 NB_CIMX_ROOT ?= $(CIMX_PREFIX)/rd890
 SB_CIMX_ROOT ?= $(CIMX_PREFIX)/sb700
-
-subdirs-y += ../../../../$(AGESA_ROOT)
diff --git a/src/mainboard/supermicro/h8scm/Makefile.inc b/src/mainboard/supermicro/h8scm/Makefile.inc
index 9a4d419..de13679 100644
--- a/src/mainboard/supermicro/h8scm/Makefile.inc
+++ b/src/mainboard/supermicro/h8scm/Makefile.inc
@@ -32,5 +32,3 @@ CIMX_PREFIX ?= $(src)/vendorcode/amd/cimx
 AGESA_ROOT ?= $(AGESA_PREFIX)/f15
 NB_CIMX_ROOT ?= $(CIMX_PREFIX)/rd890
 SB_CIMX_ROOT ?= $(CIMX_PREFIX)/sb700
-
-subdirs-y += ../../../../$(AGESA_ROOT)
diff --git a/src/mainboard/tyan/s8226/Makefile.inc b/src/mainboard/tyan/s8226/Makefile.inc
index 9a4d419..de13679 100644
--- a/src/mainboard/tyan/s8226/Makefile.inc
+++ b/src/mainboard/tyan/s8226/Makefile.inc
@@ -32,5 +32,3 @@ CIMX_PREFIX ?= $(src)/vendorcode/amd/cimx
 AGESA_ROOT ?= $(AGESA_PREFIX)/f15
 NB_CIMX_ROOT ?= $(CIMX_PREFIX)/rd890
 SB_CIMX_ROOT ?= $(CIMX_PREFIX)/sb700
-
-subdirs-y += ../../../../$(AGESA_ROOT)



More information about the coreboot-gerrit mailing list