[coreboot-gerrit] Patch set updated for coreboot: 4045ad4 buildgcc: Fix msys2 crossgcc build fail

Scott Duplichan (scott@notabs.org) gerrit at coreboot.org
Sat Dec 13 18:28:17 CET 2014


Scott Duplichan (scott at notabs.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7788

-gerrit

commit 4045ad47daa5ef4b3c4167f0d9ec2f58c0b911e3
Author: Scott Duplichan <scott at notabs.org>
Date:   Fri Dec 12 20:21:40 2014 -0600

    buildgcc: Fix msys2 crossgcc build fail
    
    A leading double slash can result when $DESTDIR/$TARGETDIR is expanded
    in the libelf portion of buildgcc. From section 4.11, last paragraph, of
    http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap04.html
        "A pathname that begins with two successive slashes may be
        interpreted in an implementation-defined manner".
    For this reason, a leading double slash in a path name should be avoided.
    In fact, the leading double slash causes buildgcc to fail when run from
    Windows/Msys2. Removing the slash from $DESTDIR/$TARGETDIR makes it
    consistent with the $DESTDIR$TARGETDIR form used elsewhere in buildgcc
    and also solves the build failure with Windows/msys2.
    
    Change-Id: Ide2bae41c07c1566f80104c3a2e2acab53de0d17
    Signed-off-by: Scott Duplichan <scott at notabs.org>
---
 util/crossgcc/buildgcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 7f2643f..a35bf33 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -437,7 +437,7 @@ printf "Building libelf ${LIBELF_VERSION} ... "
 	../${LIBELF_DIR}/configure --disable-shared --prefix=$TARGETDIR \
 		--infodir=$TARGETDIR/info CFLAGS="$HOSTCFLAGS" || touch .failed
 	$MAKE $JOBS || touch .failed
-	$MAKE install prefix=$DESTDIR/$TARGETDIR || touch .failed
+	$MAKE install prefix=$DESTDIR$TARGETDIR || touch .failed
 
 	normalize_dirs
 



More information about the coreboot-gerrit mailing list