[coreboot-gerrit] Patch set updated for coreboot: 4ffca17 amd/olivehillplus/romstage.c: remove not useful variable 'halt'

Bruce Griffith (Bruce.Griffith@se-eng.com) gerrit at coreboot.org
Thu Dec 18 19:18:22 CET 2014


Bruce Griffith (Bruce.Griffith at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7847

-gerrit

commit 4ffca17d42ec6cb134c22d6c09bbc4811097bcbe
Author: WANG Siyuan <wangsiyuanbuaa at gmail.com>
Date:   Wed Dec 17 17:30:54 2014 +0800

    amd/olivehillplus/romstage.c: remove not useful variable 'halt'
    
    The variable 'halt' is not useful and results in a compile error
    because of:
       1b2f2a07 Introduce halt()
    build error:
    src/mainboard/amd/olivehillplus/romstage.c: In function 'cache_as_ram_main':
    src/mainboard/amd/olivehillplus/romstage.c:43:15: error: declaration of 'halt' shadows a global declaration [-Werror=shadow]
    In file included from src/include/cpu/x86/lapic.h:6:0,
                     from src/mainboard/amd/olivehillplus/romstage.c:29:
    src/include/halt.h:31:32: error: shadowed declaration is here [-Werror=shadow]
    cc1: all warnings being treated as errors
    make: *** [build/mainboard/amd/olivehillplus/romstage.pre.inc] Error 1
    
    Change-Id: Id67a0dcb192fb6478115e489f46bfb07021afd90
    Signed-off-by: WANG Siyuan <SiYuan.Wang at amd.com>
    Signed-off-by: WANG Siyuan <wangsiyuanbuaa at gmail.com>
---
 src/mainboard/amd/olivehillplus/romstage.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/mainboard/amd/olivehillplus/romstage.c b/src/mainboard/amd/olivehillplus/romstage.c
index 367fa6a..f603d73 100644
--- a/src/mainboard/amd/olivehillplus/romstage.c
+++ b/src/mainboard/amd/olivehillplus/romstage.c
@@ -40,7 +40,6 @@
 void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 {
 	u32 val;
-	volatile int halt = 0;
 
 	/*
 	 *  In Hudson RRG, PMIOxD2[5:4] is "Drive strength control for
@@ -64,9 +63,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 		console_init();
 	}
 
-	if(boot_cpu()) {
-		while(halt);
-	}
 	/* Halt if there was a built in self test failure */
 	post_code(0x34);
 	report_bist_failure(bist);



More information about the coreboot-gerrit mailing list