[coreboot-gerrit] New patch to review for coreboot: e77931a Fix libpayload build compilation warnings

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Mon Dec 22 23:03:09 CET 2014


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7909

-gerrit

commit e77931a06e1179898e8b57c2c8c339614908c31f
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Thu May 15 14:06:29 2014 -0700

    Fix libpayload build compilation warnings
    
    When emerging libpayload a warning is generated about selfboot() being
    defined without a prior prototype.
    
    Addinf cbfs.h when CBFS use if compiled fixes the warning.
    
    BUG=none
    TEST=run the following
    
      $ for b in rambi storm nyan_big; do
         cros_workon-$b start libpayload
         emerge-$b libpayload
      done
    
       verify that there is no compilation warnings thrown any more
    
    Original-Change-Id: Ic9cb5571f708bb006a0d477e451fd1f3b3eb833f
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/200099
    Original-Reviewed-by: Hung-Te Lin <hungte at chromium.org>
    (cherry picked from commit 7e4aa17936b70dd08f58b3a55c6db55ea03709d7)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Ie3baaaca82fb6ec432860c638acb2a3ef9451469
---
 payloads/libpayload/include/libpayload.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h
index 824e96e..1d4d0da 100644
--- a/payloads/libpayload/include/libpayload.h
+++ b/payloads/libpayload/include/libpayload.h
@@ -60,6 +60,9 @@
 #ifdef CONFIG_LP_LAR
 #include <lar.h>
 #endif
+#ifdef CONFIG_LP_CBFS
+#include <cbfs.h>
+#endif
 
 #define MIN(a,b) ((a) < (b) ? (a) : (b))
 #define MAX(a,b) ((a) > (b) ? (a) : (b))



More information about the coreboot-gerrit mailing list