[coreboot-gerrit] New patch to review for coreboot: 9f72eee edid: fill reserved bits fields in cb_framebuffer

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7964

-gerrit

commit 9f72eeeb0076415836da921cf42ec9f95eebecda
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Dec 6 17:35:25 2014 +0100

    edid: fill reserved bits fields in cb_framebuffer
    
    If it's a 4 byte format (as per documentation), there
    are some reserved bits, so let's mark them as such...
    
    Unfortunately undone while upstreaming changes.
    
    Change-Id: I50f12cfff2c9bb9d082a5f3c3ac54c0d514d862c
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Originally-Reviewed-on: http://review.coreboot.org/7674
---
 src/lib/edid.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lib/edid.c b/src/lib/edid.c
index c047b51..4d2d55d 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1456,10 +1456,14 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
 	 * I'm not sure with grahpics you ever can.
 	 */
 	edid_fb.bits_per_pixel = edid->framebuffer_bits_per_pixel;
+	edid_fb.reserved_mask_pos = 0;
+	edid_fb.reserved_mask_size = 0;
 	switch(edid->framebuffer_bits_per_pixel){
 	case 32:
 	case 24:
 		/* packed into 4-byte words */
+		edid_fb.reserved_mask_pos = 24;
+		edid_fb.reserved_mask_size = 8;
 		edid_fb.red_mask_pos = 16;
 		edid_fb.red_mask_size = 8;
 		edid_fb.green_mask_pos = 8;
@@ -1482,8 +1486,6 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
 		return;
 	}
 
-	edid_fb.reserved_mask_pos = 0;
-	edid_fb.reserved_mask_size = 0;
 	vbe_valid = 1;
 }