[coreboot-gerrit] Patch set updated for coreboot: 9a96820 Do not tolerate compilation warnings when building libpayload

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Tue Dec 30 06:08:36 CET 2014


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7911

-gerrit

commit 9a9682069c739f0f432897a0fda347df3fbb6064
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Thu May 15 14:12:54 2014 -0700

    Do not tolerate compilation warnings when building libpayload
    
    Make sure the build breaks in case of warnings.
    
    BUG=none
    
    TEST=run the following command with the previous patch removed and
         then restored:
    
          $ for b in rambi storm nyan_big; do
             cros_workon-$b start libpayload
             emerge-$b libpayload
          done
    
          all builds succeed with the restored patch and fail when a
          compilation warning is thrown.
    
    Original-Change-Id: I9bdcd8938f59913e4ba86df5e4921b3f821ef920
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/200110
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit 16dde875950d6806cc770cdbee4d3ff456ed6f02)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I86988f8d3f1acaa6ceeabdcbfa3cede1e67c28fe
---
 payloads/libpayload/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/Makefile.inc b/payloads/libpayload/Makefile.inc
index ffe8371..dd83f88 100644
--- a/payloads/libpayload/Makefile.inc
+++ b/payloads/libpayload/Makefile.inc
@@ -57,7 +57,7 @@ CFLAGS =  $(EXTRA_CFLAGS) $(INCLUDES) -Os -pipe -nostdinc -ggdb3
 CFLAGS += -nostdlib -fno-builtin -ffreestanding -fomit-frame-pointer
 CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes
 CFLAGS += -Wwrite-strings -Wredundant-decls -Wno-trigraphs
-CFLAGS += -Wstrict-aliasing -Wshadow
+CFLAGS += -Wstrict-aliasing -Wshadow -Werror
 
 $(obj)/libpayload-config.h: $(KCONFIG_AUTOHEADER)
 	cmp $@ $< 2>/dev/null || cp $< $@



More information about the coreboot-gerrit mailing list