[coreboot-gerrit] Patch set updated for coreboot: e95178a libpaylod: fix lpgcc logic statement

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Tue Dec 30 06:08:42 CET 2014


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7912

-gerrit

commit e95178ae3e5511b230d21eb200f1f90a737608b2
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Mon May 19 15:43:47 2014 -0700

    libpaylod: fix lpgcc logic statement
    
    The -z "${V}" sure must have meant to be -n "${V}", but come to think
    of it, this check is not necessary, as the following check will
    succeed if and only if V is set to 1.
    
    BUG=none
    TEST=verified that adding V=1 to the environment causes the lpgcc
         debug statements to show up in the output.
    
    Original-Change-Id: I1eb43ef49aeb4f16aef4fbee3a1037e853f9b40f
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/200501
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-by: Marc Jones <marc.jones at se-eng.com>
    (cherry picked from commit 7d69a292b1dc90e68e539e329f019098f8af5007)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I63785fd9fc88b95d50ecced1f4f74a76ca68089c
---
 payloads/libpayload/bin/lpgcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/bin/lpgcc b/payloads/libpayload/bin/lpgcc
index a555bcb..d54669a 100755
--- a/payloads/libpayload/bin/lpgcc
+++ b/payloads/libpayload/bin/lpgcc
@@ -27,7 +27,7 @@
 ## SUCH DAMAGE.
 
 # GCC wrapper for libpayload
-if [ -z "${V}" ] && [ "${V}" = 1 ]; then
+if [ "${V}" = "1" ]; then
 	DEBUGME=1
 else
 	DEBUGME=0



More information about the coreboot-gerrit mailing list