[coreboot-gerrit] Patch merged into coreboot/master: 1c8e91f libpayload: video: Check for 'console' pointer before dereferencing it

gerrit at coreboot.org gerrit at coreboot.org
Tue Dec 30 19:11:36 CET 2014


the following patch was just integrated into master:
commit 1c8e91f21ab656c393454b774984911155ede827
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue May 20 17:56:25 2014 -0700

    libpayload: video: Check for 'console' pointer before dereferencing it
    
    Seems that the 'if (cursor_enabled)' check in
    video_console_fixup_cursor() that was removed in chromium.org 1f880bca0 really
    meant to check for 'if (console)'. Looks like the whole video console
    driver is built extra robust to not fail no matter how screwed up the
    console is, so let's add this missing check here as well. Also fixed up
    a few other missing 'if (!console)' checks while I'm at it.
    
    However, what payloads should really be doing is check the return value
    of video_(console_)init() and not call the other video functions if that
    failed. This also adapts video_console_init() to correctly pass through
    the return value for that purpose (something that seems to have been
    overlooked in the dd9e4e58 refactoring).
    
    BUG=chrome-os-partner:28494
    TEST=None. I don't know what Dave did to trigger this in the first
    place, but it's pretty straight-forward.
    
    Original-Change-Id: I1b9f09d49dc70dacf20621b19e081c754d4814f7
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/200688
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    (cherry picked from commit 3f01d1dc0974774f0b3ba5fc4e069978f266f2fc)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I98c1d8360539b457e6df07cbcf799acaf6c4631b
    Reviewed-on: http://review.coreboot.org/7910
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/7910 for details.

-gerrit



More information about the coreboot-gerrit mailing list