[coreboot-gerrit] Patch set updated for coreboot: 46c33f5 cpu: Only ask for length and address of ucode when included in CBFS

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Tue Feb 11 02:14:05 CET 2014


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4481

-gerrit

commit 46c33f58d9f52ea6c40635dcff51a3473c15577f
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Dec 4 22:05:15 2013 -0600

    cpu: Only ask for length and address of ucode when included in CBFS
    
    The original intention was to only run prompt for CPU_MICROCODE_CBFS_LOC
    and CPU_MICROCODE_CBFS_LEN when a microcode file was included in CBFS.
    This happens when either CPU_MICROCODE_CBFS_GENERATE or
    CPU_MICROCODE_CBFS_EXTERNAL is selected, however, Kconfig checked that
    against CPU_MICROCODE_IN_CBFS. The end result was that length and
    location were always prompted, even when the user elected not to include
    any microcode.
    
    Instead, check if microcode is added to CBFS during the build.
    
    Change-Id: I9b61d022bcc879549e844bdfd5d5109554cc1a16
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/cpu/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig
index f3883d3..a300549 100644
--- a/src/cpu/Kconfig
+++ b/src/cpu/Kconfig
@@ -173,12 +173,12 @@ config CPU_MICROCODE_FILE
 
 config CPU_MICROCODE_CBFS_LOC
 	  hex "Microcode address in CBFS"
-	  depends on CPU_MICROCODE_IN_CBFS
+	  depends on CPU_MICROCODE_ADDED_DURING_BUILD
 	  default 0
 
 config CPU_MICROCODE_CBFS_LEN
 	  hex "Microcode length in CBFS"
-	  depends on CPU_MICROCODE_IN_CBFS
+	  depends on CPU_MICROCODE_ADDED_DURING_BUILD
 	  default 0xC000
 	  help
 		The microcode needs a specific length to get correctly



More information about the coreboot-gerrit mailing list