[coreboot-gerrit] Patch set updated for coreboot: 714c10d Eliminate some ASL warnings

Oskar Enoksson (enok@lysator.liu.se) gerrit at coreboot.org
Tue Feb 11 23:22:03 CET 2014


Oskar Enoksson (enok at lysator.liu.se) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5189

-gerrit

commit 714c10d58294ff8f628b62c959f2ad8d86f7eee7
Author: Oskar Enoksson <enok at lysator.liu.se>
Date:   Tue Feb 11 23:19:02 2014 +0100

    Eliminate some ASL warnings
    
    The ASL compiler warned about "Control Method should be made Serialized
    (due to creation of named objects within)". This commit eliminates the
    warnings by changing those NonSerialized into Serialized.
    
    Change-Id: I639e769cf7a9428c34268e0c555a30c7dee1e04c
    Signed-off-by: Oskar Enoksson <enok at lysator.liu.se>
---
 src/northbridge/amd/amdk8/util.asl            | 6 +++---
 src/superio/winbond/w83627hf/acpi/superio.asl | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/northbridge/amd/amdk8/util.asl b/src/northbridge/amd/amdk8/util.asl
index 57a2cf9..921de4e 100644
--- a/src/northbridge/amd/amdk8/util.asl
+++ b/src/northbridge/amd/amdk8/util.asl
@@ -109,7 +109,7 @@ Scope (\_SB)
 	}
 
 	/* GetBusResources(Node, Link) */
-	Method (GWBN, 2, NotSerialized)
+	Method (GWBN, 2, Serialized)
 	{
 		Name (BUF0, ResourceTemplate ()
 		{
@@ -149,7 +149,7 @@ Scope (\_SB)
 	}
 
 	/* GetMemoryResources(Node, Link) */
-	Method (GMEM, 2, NotSerialized)
+	Method (GMEM, 2, Serialized)
 	{
 		Name (BUF0, ResourceTemplate ()
 		{
@@ -214,7 +214,7 @@ Scope (\_SB)
 	}
 
 	/* GetIOResources(Node, Link) */
-	Method (GIOR, 2, NotSerialized)
+	Method (GIOR, 2, Serialized)
 	{
 		Name (BUF0, ResourceTemplate ()
 		{
diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl
index 8531339..a8a184a 100644
--- a/src/superio/winbond/w83627hf/acpi/superio.asl
+++ b/src/superio/winbond/w83627hf/acpi/superio.asl
@@ -655,7 +655,7 @@ Device(SIO) {
 			EXCM ()
 		}
 
-		Method (_CRS)
+		Method (_CRS, 0, Serialized)
 		{
 			Name (CRS, ResourceTemplate () {
 				IO (Decode16, 0x0000, 0x0000, 0x01, 0x08, IO0)
@@ -1099,7 +1099,7 @@ Device(SIO) {
 			Notify(PS2M, 1)
 		}
 
-		Method (_CRS)
+		Method (_CRS, 0, Serialized)
 		{
 			Name (CRS, ResourceTemplate () {
 				IRQNoFlags (IRQX) {}
@@ -1203,7 +1203,7 @@ Device(SIO) {
 			EXCM ()
 		}
 
-		Method (_CRS)
+		Method (_CRS, 0, Serialized)
 		{
 			Name (CRS, ResourceTemplate () {
 				IRQNoFlags (IRQX) {}
@@ -1425,7 +1425,7 @@ Device(SIO) {
 			EXCM ()
 		}
 
-		Method (_CRS)
+		Method (_CRS, 0, Serialized)
 		{
 			Name (CRS, ResourceTemplate () {
 				IO (Decode16, 0x0000, 0x0000, 0x08, 0x02, IO0)



More information about the coreboot-gerrit mailing list