[coreboot-gerrit] Patch set updated for coreboot: 94f0d58 vendorcode/amd/agesa/f*: Improve gcccar.inc assembler compatibility.

[Edward O'Callaghan (eocallaghan@alterapraxis.com)]

Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5277

-gerrit

commit 94f0d5800f121b44ca1bcf6a19dbdf2f620505b5
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Feb 21 12:43:07 2014 +1100

    vendorcode/amd/agesa/f*: Improve gcccar.inc assembler compatibility.
    
    A comparison with a two's complement in gcccar.inc has dubious
    GAS/AT&T notation. Clang miss-parses 0x-1 as an invalid hexadecimal
    number.
    
    Change-Id: I88baa5c2513f062ff309df05916a3832b9bd9bb1
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/vendorcode/amd/agesa/f10/gcccar.inc   | 2 +-
 src/vendorcode/amd/agesa/f12/gcccar.inc   | 2 +-
 src/vendorcode/amd/agesa/f14/gcccar.inc   | 2 +-
 src/vendorcode/amd/agesa/f15/gcccar.inc   | 2 +-
 src/vendorcode/amd/agesa/f15tn/gcccar.inc | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/vendorcode/amd/agesa/f10/gcccar.inc b/src/vendorcode/amd/agesa/f10/gcccar.inc
index 61a8d3e..11f50db 100644
--- a/src/vendorcode/amd/agesa/f10/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f10/gcccar.inc
@@ -827,7 +827,7 @@ fam14_disable_stack_hook_exit:
 
     LOCAL   node_core_f14_exit
 
-    cmp     $0x-1, %si                      # Has node/core already been discovered?
+    cmp     $-1, %si                    # Has node/core already been discovered?
     jnz     node_core_f14_exit          # Br if yes
 
     AMD_CPUID   $CPUID_MODEL
diff --git a/src/vendorcode/amd/agesa/f12/gcccar.inc b/src/vendorcode/amd/agesa/f12/gcccar.inc
index d7da81d..22564cb 100644
--- a/src/vendorcode/amd/agesa/f12/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f12/gcccar.inc
@@ -821,7 +821,7 @@ fam14_disable_stack_hook_exit:
 
     LOCAL   node_core_f14_exit
 
-    cmp     $0x-1, %si                      # Has node/core already been discovered?
+    cmp     $-1, %si                    # Has node/core already been discovered?
     jnz     node_core_f14_exit          # Br if yes
 
     AMD_CPUID   $CPUID_MODEL
diff --git a/src/vendorcode/amd/agesa/f14/gcccar.inc b/src/vendorcode/amd/agesa/f14/gcccar.inc
index 7037344..40e0e31 100644
--- a/src/vendorcode/amd/agesa/f14/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f14/gcccar.inc
@@ -835,7 +835,7 @@ fam14_disable_stack_hook_exit:
 
     LOCAL   node_core_f14_exit
 
-    cmp     $0x-1, %si                      # Has node/core already been discovered?
+    cmp     $-1, %si                    # Has node/core already been discovered?
     jnz     node_core_f14_exit          # Br if yes
 
     AMD_CPUID   $CPUID_MODEL
diff --git a/src/vendorcode/amd/agesa/f15/gcccar.inc b/src/vendorcode/amd/agesa/f15/gcccar.inc
index b20c77e..c88709c 100644
--- a/src/vendorcode/amd/agesa/f15/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f15/gcccar.inc
@@ -842,7 +842,7 @@ fam14_disable_stack_hook_exit:
 
     LOCAL   node_core_f14_exit
 
-    cmp     $0x-1, %si                      # Has node/core already been discovered?
+    cmp     $-1, %si                    # Has node/core already been discovered?
     jnz     node_core_f14_exit          # Br if yes
 
     AMD_CPUID   $CPUID_MODEL
diff --git a/src/vendorcode/amd/agesa/f15tn/gcccar.inc b/src/vendorcode/amd/agesa/f15tn/gcccar.inc
index c76ad16..d6dd49a 100644
--- a/src/vendorcode/amd/agesa/f15tn/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f15tn/gcccar.inc
@@ -875,7 +875,7 @@ fam14_disable_stack_hook_exit:
 
     LOCAL   node_core_f14_exit
 
-    cmp     $0x-1, %si                      # Has node/core already been discovered?
+    cmp     $-1, %si                    # Has node/core already been discovered?
     jnz     node_core_f14_exit          # Br if yes
 
     AMD_CPUID   $CPUID_MODEL