[coreboot-gerrit] Patch set updated for coreboot: ace97fe acpi/ec: Add missing delay

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Mon Jan 6 10:18:27 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4617

-gerrit

commit ace97fe05e5c2c55ed7db01b481766be8c216cb3
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Jan 5 06:50:10 2014 +0100

    acpi/ec: Add missing delay
    
    Without this delay on fast systems like X230 the port is read before it's
    updated.
    
    Change-Id: I3e01fc348cc5170cec108a05095ba301055ed6b0
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/ec/acpi/ec.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/ec/acpi/ec.c b/src/ec/acpi/ec.c
index ab287d6..c24ddbd 100644
--- a/src/ec/acpi/ec.c
+++ b/src/ec/acpi/ec.c
@@ -73,6 +73,8 @@ int send_ec_data(u8 data)
 		// return -1;
 	}
 
+	udelay(10);
+
 	outb(data, ec_data_reg);
 
 	return 0;
@@ -104,6 +106,8 @@ u8 recv_ec_data(void)
 		// return -1;
 	}
 
+	udelay(10);
+
 	data = inb(ec_data_reg);
 	printk(BIOS_SPEW, "recv_ec_data: 0x%02x\n", data);
 



More information about the coreboot-gerrit mailing list