[coreboot-gerrit] Patch set updated for coreboot: 97393e4 boardstatus: Fix creation of links to configs.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Mon Jan 20 03:42:49 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4757

-gerrit

commit 97393e4cb7f20b7a066f45bda38c0911a05233d4
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Mon Jan 20 03:18:20 2014 +0100

    boardstatus: Fix creation of links to configs.
    
    The unusual construction ls + grep + while read fails
    for unknown reason. Use standard for x in * consruction
    instead.
    
    Change-Id: Ibcdf5e18543587f71a605bae2d0df72b6a286a5b
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 util/board_status/to-wiki/towiki.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/util/board_status/to-wiki/towiki.sh b/util/board_status/to-wiki/towiki.sh
index fd0dcf0..a9fb520 100755
--- a/util/board_status/to-wiki/towiki.sh
+++ b/util/board_status/to-wiki/towiki.sh
@@ -28,7 +28,10 @@ while read line; do
 
 		detailed="$detailed[[Board:$vendor_board|$vendor_board]] at $datetime_human$nl"
 		detailed="$detailed[$CODE_GITWEB$upstream upstream tree] ($nl"
-		ls $vendor_board/$commit/$datetime/* |grep -v '/revision.txt$' | while read file; do
+		for file in "$vendor_board/$commit/$datetime/"*; do
+			if [ "$file" = "$vendor_board/$commit/$datetime/revision.txt" ]; then
+				continue
+			fi
 			detailed="$detailed[$STATUS_GITWEB$file `basename $file`] $nl"
 		done
 		detailed="$detailed)$nl$nl"



More information about the coreboot-gerrit mailing list