[coreboot-gerrit] Patch set updated for coreboot: 3c408b3 libpayload/libc/hexdump.c: Use `p` as conversion specifier for void * pointer argument

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Tue Jan 21 14:47:58 CET 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4767

-gerrit

commit 3c408b345efc9a1f4829f8a1ac18290ff2af888c
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Jan 21 12:08:18 2014 +0100

    libpayload/libc/hexdump.c: Use `p` as conversion specifier for void * pointer argument
    
    Address the following warning by using the correct conversion specifier.
    
    	    CC         libc/hexdump.libc.o
    	libc/hexdump.c: In function 'hexdump':
    	libc/hexdump.c:52:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'void *' [-Wformat]
    
    Also remove the zero padding as that results in the warning below.
    
    	    CC libc/hexdump.libc.o
    	libc/hexdump.c: In function 'hexdump':
    	libc/hexdump.c:52:4: warning: '0' flag used with '%p' gnu_printf format [-Wformat]
    
    Change-Id: Ie5c279ef90bd9ed5e2624bf852dcff1f06531a13
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 payloads/libpayload/libc/hexdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index e4aa8b9..814adf2 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -49,7 +49,7 @@ void hexdump(void *memory, int length)
 		}
 
 		if (all_zero < 2) {
-			printf("%08lx:", memory + i);
+			printf("%8p:", memory + i);
 			for (j = 0; j < 16; j++)
 				printf(" %02x", m[i + j]);
 			printf("  ");



More information about the coreboot-gerrit mailing list