[coreboot-gerrit] Patch merged into coreboot/master: 60db58e CAR_GLOBAL: Define section details once
gerrit at coreboot.org
gerrit at coreboot.org
Tue Jan 21 19:05:27 CET 2014
the following patch was just integrated into master:
commit 60db58e8b876963bee4b568c536bfb538a2b9e85
Author: Patrick Georgi <patrick at georgi-clan.de>
Date: Sat Jan 18 16:38:12 2014 +0100
CAR_GLOBAL: Define section details once
Improve clang compatibility by dropping an opaque hack
The section attribute was only ever meant for specifying
section names, not their properties - otherwise they would
have provided section(name,attribute,class) instead of only
section(name).
The hack to add attribute and class to the name, and commenting
out the "real" definitions inserted by the compiler (see the
terminating "#"), is refused by clang developers.
This is a cleaner implementation in that the section is first
declared with its properties, then used later-on, expecting that
later conflicting declarations are ignored.
It can still break in two ways:
1. The assembler or linker could complain about a section declared
in two different ways.
2. The assembler could just use the latest declaration, not the first,
to determine the section's properties.
I won't sort these out unless they actually happen.
Change-Id: I4640b0fc397b301102dde6dc3ea1a078ce9edf1c
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
See http://review.coreboot.org/4716 for details.
-gerrit
More information about the coreboot-gerrit
mailing list