[coreboot-gerrit] New patch to review for coreboot: 47f4222 pc80/keyboard: Ignore interface test failure.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Jan 26 03:56:43 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4816

-gerrit

commit 47f4222f6109b8ef6108613c453100850e4a3524
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Jan 26 03:55:01 2014 +0100

    pc80/keyboard: Ignore interface test failure.
    
    On Asus A8N-E this test fails but if failure is ignored keyboard works.
    
    Change-Id: Ifeeff2f41537b35bc90a679f956fea830b94292c
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/drivers/pc80/keyboard.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/drivers/pc80/keyboard.c b/src/drivers/pc80/keyboard.c
index dd6321e..5026f76 100644
--- a/src/drivers/pc80/keyboard.c
+++ b/src/drivers/pc80/keyboard.c
@@ -156,7 +156,8 @@ static int kbc_self_test(void)
 	if (self_test != 0x00) {
 		printk(BIOS_ERR, "Keyboard Interface test failed: 0x%x\n",
 		       self_test);
-		return 0;
+		/* Ignore this error. It's not always fatal.  */
+		return 1;
 	}
 
 	return 1;



More information about the coreboot-gerrit mailing list