[coreboot-gerrit] New patch to review for coreboot: 38dc99f rambi: Change RAM_ID GPIOs to GPIO_INPUT

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue Jan 28 03:57:57 CET 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5053

-gerrit

commit 38dc99f0bb076a3473b5d7f48b5266018cbcbf4c
Author: Shawn Nematbakhsh <shawnn at chromium.org>
Date:   Thu Jan 16 17:52:21 2014 -0800

    rambi: Change RAM_ID GPIOs to GPIO_INPUT
    
    RAM_ID GPIOs were previously changed to GPIO_FUNC0 to configure for MMIO
    access when legacy was the default. Now, MMIO is the default, so these
    GPIOs can conform to the normal labeling scheme. This change should have
    no functional impact.
    
    BUG=chrome-os-partner:25043
    TEST=Manual on Rambi. Verify RAM_ID GPIOs on test unit are read with
    identical values as before.
    BRANCH=Rambi.
    
    Change-Id: I2f76395064ea6e4170b2eaad6e67bfc1aa22b54e
    Reviewed-on: https://chromium-review.googlesource.com/182934
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Commit-Queue: Shawn Nematbakhsh <shawnn at chromium.org>
    Signed-off-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Tested-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/rambi/gpio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/rambi/gpio.c b/src/mainboard/google/rambi/gpio.c
index d551a15..89e9c8c 100644
--- a/src/mainboard/google/rambi/gpio.c
+++ b/src/mainboard/google/rambi/gpio.c
@@ -200,9 +200,9 @@ static const struct soc_gpio_map gpssus_gpio_map[] = {
 	GPIO_NC,	/* S534 - NC */
 	GPIO_OUT_HIGH,	/* S535 - LTE_DISABLE_L */
 	GPIO_NC,	/* S536 - NC */
-	GPIO_FUNC0,	/* S537 - RAM_ID0 */
-	GPIO_FUNC0,	/* S538 - RAM_ID1 */
-	GPIO_FUNC0,	/* S539 - RAM_ID2 */
+	GPIO_INPUT,	/* S537 - RAM_ID0 */
+	GPIO_INPUT,	/* S538 - RAM_ID1 */
+	GPIO_INPUT,	/* S539 - RAM_ID2 */
 	GPIO_NC,	/* S540 - NC */
 	GPIO_NC,	/* S541 - NC */
 	GPIO_NC,	/* S542 - NC */



More information about the coreboot-gerrit mailing list