[coreboot-gerrit] New patch to review for coreboot: 132d48e baytrail: Set SOC power budget values for SdpProfile 2&3

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue Jan 28 03:57:59 CET 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5055

-gerrit

commit 132d48ea110279fef07efebe1d2a3cc08ed483d7
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Fri Jan 17 13:22:02 2014 -0800

    baytrail: Set SOC power budget values for SdpProfile 2&3
    
    These values are for the 2 and 4 core B-step parts.
    
    BUG=chrome-os-partner:17279
    BRANCH=baytrail
    TEST=boot on rambi and check for valid GPU power values from DPTF
    
    Change-Id: I2772cb9dbf17560fc31f871a111f32131c7e5105
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/183101
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/183102
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/baytrail/dptf.c | 4 ++--
 src/soc/intel/baytrail/gfx.c  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/soc/intel/baytrail/dptf.c b/src/soc/intel/baytrail/dptf.c
index 691e220..184f694 100644
--- a/src/soc/intel/baytrail/dptf.c
+++ b/src/soc/intel/baytrail/dptf.c
@@ -37,8 +37,8 @@ static const struct reg_script dptf_init_settings[] = {
 	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_TTE_XXPROCHOT, 0x00061029),
 	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_TTE_SLM0, 0x00001029),
 	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_TTE_SLM1, 0x00001029),
-	/* ratio 10 = 1333mhz for 2.5W fanless */
-	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_SOC_POWER_BUDGET, 0x00000A00),
+	/* ratio 11 = 1466mhz for mid and entry celeron */
+	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_SOC_POWER_BUDGET, 0x00000B00),
 	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_SOC_ENERGY_CREDIT, 0x00000002),
 	REG_SCRIPT_END,
 };
diff --git a/src/soc/intel/baytrail/gfx.c b/src/soc/intel/baytrail/gfx.c
index 7a8660c..3c779e1 100644
--- a/src/soc/intel/baytrail/gfx.c
+++ b/src/soc/intel/baytrail/gfx.c
@@ -142,7 +142,7 @@ static const struct reg_script gfx_init_script[] = {
 
 	/* Program PUNIT_GPU_EC_VIRUS based on DPTF SDP */
 	/* SDP Profile 4 == 0x11940, others 0xcf08 */
-	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_GPU_EC_VIRUS, 0x11940),
+	REG_IOSF_WRITE(IOSF_PORT_PMC, PUNIT_GPU_EC_VIRUS, 0xcf08),
 
 	/* GfxPause */
 	REG_RES_WRITE32(PCI_BASE_ADDRESS_0, 0xa000, 0x00071388),



More information about the coreboot-gerrit mailing list