[coreboot-gerrit] Patch set updated for coreboot: 1013cdf baytrail: move early init to before mainboard

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue Jan 28 05:23:26 CET 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4871

-gerrit

commit 1013cdf449af88973dd0fd5f21fd28d59ba63663
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Oct 8 16:54:18 2013 -0500

    baytrail: move early init to before mainboard
    
    It's helpful to have a lot of the early init happen
    before the handoff to mainboard. One example of this
    need is having the BARs programmed so that the mainboard
    can read board-specific gpios.
    
    BUG=chrome-os-partner:22865
    BRANCH=None
    TEST=Built. Booted and saw console outout in bayleybay
         mainboard.
    
    Signed-off-by; Aaron Durbin <adurbin at chromium.org>
    
    Change-Id: I030d7b4f9061ad7501049e8e204ea12255061fbe
    Reviewed-on: https://chromium-review.googlesource.com/172290
    Tested-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Commit-Queue: Aaron Durbin <adurbin at chromium.org>
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/baytrail/romstage/romstage.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/soc/intel/baytrail/romstage/romstage.c b/src/soc/intel/baytrail/romstage/romstage.c
index 0035019..4228615 100644
--- a/src/soc/intel/baytrail/romstage/romstage.c
+++ b/src/soc/intel/baytrail/romstage/romstage.c
@@ -107,17 +107,6 @@ void * asmlinkage romstage_main(unsigned long bist,
 	/* Save romstage begin */
 	mark_ts(&rp, timestamp_get());
 
-	/* Call into mainboard. */
-	mainboard_romstage_entry(&rp);
-
-	return setup_stack_and_mttrs();
-}
-
-/* Entry from the mainboard. */
-void romstage_common(struct romstage_params *params)
-{
-	struct romstage_handoff *handoff;
-
 	program_base_addresses();
 
 	tco_disable();
@@ -132,6 +121,17 @@ void romstage_common(struct romstage_params *params)
 
 	gfx_init();
 
+	/* Call into mainboard. */
+	mainboard_romstage_entry(&rp);
+
+	return setup_stack_and_mttrs();
+}
+
+/* Entry from the mainboard. */
+void romstage_common(struct romstage_params *params)
+{
+	struct romstage_handoff *handoff;
+
 	mark_ts(params, timestamp_get());
 
 	/* Initialize RAM */



More information about the coreboot-gerrit mailing list