[coreboot-gerrit] New patch to review for coreboot: ce752ac ibexpeak/azalia: Remove C4-register extended init.
Vladimir Serbinenko (phcoder@gmail.com)
gerrit at coreboot.org
Tue Jan 28 14:30:53 CET 2014
Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5074
-gerrit
commit ce752ac57821e4f33fcc2b4e9b0f8c4be9d41eb1
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date: Tue Jan 28 14:28:49 2014 +0100
ibexpeak/azalia: Remove C4-register extended init.
This sequence was derived from BD82X6X and on ibexpeak it inadvertently
disables interrupts. In older kernels it wasn't a problem but in new kernel
it makes codec probe fail.
Change-Id: I40184ae8c4cfe758869af1a1565b88f0a238150e
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
src/southbridge/intel/ibexpeak/azalia.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/src/southbridge/intel/ibexpeak/azalia.c b/src/southbridge/intel/ibexpeak/azalia.c
index 0e3d365..395832b 100644
--- a/src/southbridge/intel/ibexpeak/azalia.c
+++ b/src/southbridge/intel/ibexpeak/azalia.c
@@ -278,26 +278,10 @@ static void azalia_init(struct device *dev)
reg8 |= (1 << 6);
pci_write_config8(dev, 0x43, reg8);
- /* Additional programming steps */
- reg32 = pci_read_config32(dev, 0xc4);
- reg32 |= (1 << 13);
- pci_write_config32(dev, 0xc4, reg32);
-
- reg32 = pci_read_config32(dev, 0xc4);
- reg32 |= (1 << 10);
- pci_write_config32(dev, 0xc4, reg32);
-
reg32 = pci_read_config32(dev, 0xd0);
reg32 &= ~(1 << 31);
pci_write_config32(dev, 0xd0, reg32);
- if (dev->device == 0x1e20) {
- /* Additional step on Panther Point */
- reg32 = pci_read_config32(dev, 0xc4);
- reg32 |= (1 << 17);
- pci_write_config32(dev, 0xc4, reg32);
- }
-
/* Set Bus Master */
reg32 = pci_read_config32(dev, PCI_COMMAND);
pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER);
More information about the coreboot-gerrit
mailing list