[coreboot-gerrit] New patch to review for coreboot: ee1f8ca cbfstool: Fix build errors when building with clang

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Wed Jan 29 21:30:05 CET 2014


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5081

-gerrit

commit ee1f8ca00f2281a4ffd5558d9c4fa375cd649064
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Jan 29 14:27:52 2014 -0600

    cbfstool: Fix build errors when building with clang
    
    Now that we can set CC to an arbitrary compiler, fix issues that clang
    finds. Luckily, there were only two trivial errors.
    
    Change-Id: I0fd1f0f263a8ab7004f39cd36ed42d1a1cba5c04
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 util/cbfstool/linux_trampoline.c | 2 +-
 util/cbfstool/lzma/C/LzmaEnc.c   | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/util/cbfstool/linux_trampoline.c b/util/cbfstool/linux_trampoline.c
index 79d1576..368d63a 100644
--- a/util/cbfstool/linux_trampoline.c
+++ b/util/cbfstool/linux_trampoline.c
@@ -137,5 +137,5 @@ const unsigned char trampoline[] = {
 0x02, 0x09, 0x00, 0xf4, 0xeb, 0xfd
 };
 
-void * const trampoline_start = &trampoline;
+const void * const trampoline_start = &trampoline;
 const unsigned long trampoline_size = sizeof trampoline;
diff --git a/util/cbfstool/lzma/C/LzmaEnc.c b/util/cbfstool/lzma/C/LzmaEnc.c
index 9b18b19..a129507 100644
--- a/util/cbfstool/lzma/C/LzmaEnc.c
+++ b/util/cbfstool/lzma/C/LzmaEnc.c
@@ -2079,8 +2079,6 @@ static void LzmaEnc_Finish(CLzmaEncHandle pp)
   CLzmaEnc *p = (CLzmaEnc *)pp;
   if (p->mtMode)
     MatchFinderMt_ReleaseStream(&p->matchFinderMt);
-  #else
-  pp = pp;
   #endif
 }
 



More information about the coreboot-gerrit mailing list