[coreboot-gerrit] Patch merged into coreboot/master: 5b9e6f1 libpayload: Drop obsolete setting of reg_base in [oex]hci

gerrit at coreboot.org gerrit at coreboot.org
Thu Jul 10 20:55:56 CEST 2014


the following patch was just integrated into master:
commit 5b9e6f175f7778b16ac988e2de4e271751ecc019
Author: Nico Huber <nico.huber at secunet.com>
Date:   Thu Jul 10 12:56:34 2014 +0200

    libpayload: Drop obsolete setting of reg_base in [oex]hci
    
    Setting of `controller->reg_base` is of no use here, as it is never read
    (in another function) later. Looks like this pattern originated from uhci.c
    where it makes sense.
    
    By removing the indirection through `reg_base` we also fix a possible
    truncation to u32.
    
    Change-Id: I5c99c5bf1f5b1d6c04bd84d87fd3e275fd7d0411
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
    Reviewed-on: http://review.coreboot.org/6251
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>


See http://review.coreboot.org/6251 for details.

-gerrit



More information about the coreboot-gerrit mailing list