[coreboot-gerrit] New patch to review for coreboot: f0c08a5 model_fxx/processor_name.c, hudson/lpc.c: add missing break statements
Daniele Forsi (dforsi@gmail.com)
gerrit at coreboot.org
Sat Jul 26 10:51:24 CEST 2014
Daniele Forsi (dforsi at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6372
-gerrit
commit f0c08a5a93b91ec2a5974faebe27a5f1c32d5f25
Author: Daniele Forsi <dforsi at gmail.com>
Date: Sat Jul 26 10:32:34 2014 +0200
model_fxx/processor_name.c, hudson/lpc.c: add missing break statements
Found by Cppcheck 1.65. NOT compile-tested. Fixes:
[src/cpu/amd/model_fxx/processor_name.c:236] -> [src/cpu/amd/model_fxx/processor_name.c:240]: (warning) Variable 'processor_name_string' is reassigned a value before the old one has been used. 'break;' missing?
[src/southbridge/amd/agesa/hudson/lpc.c:232] -> [src/southbridge/amd/agesa/hudson/lpc.c:235]: (warning) Variable 'rsize' is reassigned a value before the old one has been used. 'break;' missing?
Change-Id: I4a5c947fd5cc5797eb026475ec7036bc5eaf58db
Signed-off-by: Daniele Forsi <dforsi at gmail.com>
---
src/cpu/amd/model_fxx/processor_name.c | 1 +
src/southbridge/amd/agesa/hudson/lpc.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/cpu/amd/model_fxx/processor_name.c b/src/cpu/amd/model_fxx/processor_name.c
index 81cd470..0d913d7 100644
--- a/src/cpu/amd/model_fxx/processor_name.c
+++ b/src/cpu/amd/model_fxx/processor_name.c
@@ -235,6 +235,7 @@ int init_processor_name(void)
case 0x30052:
processor_name_string =
"AMD Sempron(tm) Processor RR50p";
+ break;
case 0x30064:
case 0x30068:
processor_name_string =
diff --git a/src/southbridge/amd/agesa/hudson/lpc.c b/src/southbridge/amd/agesa/hudson/lpc.c
index c8051ec..20212ef 100644
--- a/src/southbridge/amd/agesa/hudson/lpc.c
+++ b/src/southbridge/amd/agesa/hudson/lpc.c
@@ -230,6 +230,7 @@ static void hudson_lpc_enable_childrens_resources(device_t dev)
case 0x480:
set_x |= (1 << 17);
rsize = 0x40;
+ break;
case 0x500:
set_x |= (1 << 18);
rsize = 0x40;
More information about the coreboot-gerrit
mailing list